FIX skip space after delimiter in fetch_openml when using pandas parser #25312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
ping @adrinjalali since you already know the context |
This was referenced Jan 6, 2023
thomasjpfan
reviewed
Jan 7, 2023
Member
thomasjpfan
left a comment
There was a problem hiding this comment.
The new data-v1-* file is much larger (625K) compared to the other data files:
cd sklearn/datasets/tests/data/openml
find . -name '*data*' | xargs du -sh
4.0K ./id_561/data-v1-dl-52739.arff.gz
4.0K ./id_62/data-v1-dl-52352.arff.gz
8.0K ./id_40589/data-v1-dl-4644182.arff.gz
4.0K ./id_40675/data-v1-dl-4965250.arff.gz
4.0K ./id_1/data-v1-dl-1.arff.gz
8.0K ./id_42585/data-v1-dl-21854866.arff.gz
4.0K ./id_292/data-v1-dl-49822.arff.gz
652K ./id_1590/data-v1-dl-1595261.arff.gz
4.0K ./id_61/data-v1-dl-61.arff.gz
32K ./id_40945/data-v1-dl-16826755.arff.gz
4.0K ./id_1119/data-v1-dl-54002.arff.gz
4.0K ./id_2/data-v1-dl-1666876.arff.gz
20K ./id_3/data-v1-dl-3.arff.gz
8.0K ./id_40966/data-v1-dl-17928620.arff.gz
For testing, can we use a subset of the data instead?
Member
Author
|
Yes, for the regression, I can select the 10 first samples. It would be more than enough. |
thomasjpfan
approved these changes
Jan 11, 2023
Member
thomasjpfan
left a comment
There was a problem hiding this comment.
There is a merge conflict, otherwise LGTM
jjerphan
pushed a commit
to jjerphan/scikit-learn
that referenced
this pull request
Jan 20, 2023
…er (scikit-learn#25312) Co-authored-by: Adrin Jalali <[email protected]> closes scikit-learn#25311
jjerphan
pushed a commit
to jjerphan/scikit-learn
that referenced
this pull request
Jan 20, 2023
…er (scikit-learn#25312) Co-authored-by: Adrin Jalali <[email protected]> closes scikit-learn#25311
jjerphan
pushed a commit
to jjerphan/scikit-learn
that referenced
this pull request
Jan 23, 2023
…er (scikit-learn#25312) Co-authored-by: Adrin Jalali <[email protected]> closes scikit-learn#25311
adrinjalali
added a commit
that referenced
this pull request
Jan 24, 2023
…er (#25312) Co-authored-by: Adrin Jalali <[email protected]> closes #25311
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #25311
Workaround for inconsistencies between liac-arff and pandas parser