MAINT Remove -Wcpp warnings when compiling arrayfuncs #25415

rprkh · 2023-01-17T07:41:06Z

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Prevents -Wcpp warnings coming from the deprecated cnp.ndarray.

Any other comments?

glemaitre · 2023-01-17T11:44:15Z

sklearn/utils/arrayfuncs.pyx

-
-
-def min_pos(cnp.ndarray X):
+def min_pos(ndarray[float64_t] X):


It seems that X should be of a fused type floating.

rprkh · 2023-01-18T07:11:22Z

@glemaitre I think the test failures are coming from pytest -v sklearn/tests/test_common.py::test_configure

sklearn/utils/arrayfuncs.pyx

jjerphan

LGTM. Thank you, @rprkh.

sklearn/utils/arrayfuncs.pyx

rprkh · 2023-01-20T15:43:30Z

Thanks a lot @Vincent-Maladiere for your suggestions and explanation. I included the changes.

Vincent-Maladiere · 2023-01-23T09:46:07Z

I can't reproduce the error of the CI (all tests pass on my laptop). Could we rerun it?

rprkh · 2023-01-23T17:44:44Z

I re-ran some of the tests on my laptop and they pass. I don't know why the CI breaks for Linux and Windows but passes for all the others.

sklearn/utils/arrayfuncs.pyx

…h/scikit-learn into wcpp_warnings

rprkh · 2023-01-31T16:45:16Z

I included the suggestions, but the tests still seem to fail for the Windows and Linux builds. I'm not sure why only these two are failing but the others seem to pass.

Vincent-Maladiere · 2023-01-31T20:25:28Z

Hi @rprkh, I tried to reproduce with conda-lock the environment used for the failing test on linux but still couldn't reproduce.

conda install conda-lock
conda-lock install --name testvenv ./build_tools/azure/py38_conda_defaults_openblas_linux-64_conda.lock
conda activate testvenv
make test-code

cc @lesteve, WDYT?

lesteve · 2023-02-01T08:38:56Z

After failing to reproduce, I looked closer at azure-pipelines.yml, both failing builds have

SKLEARN_ENABLE_DEBUG_CYTHON_DIRECTIVES: '1'

So maybe try to set the env variable (export SKLEARN_ENABLE_DEBUG_CYTHON_DIRECTIVES=1) rebuild and see whether you manage to reproduce?

lesteve · 2023-02-01T08:50:36Z

Follow-up I do reproduce the issue followin the above instructions and with:

pytest sklearn/covariance/tests/test_graphical_lasso.py

Output:

============================================================================================================ test session starts =============================================================================================================
platform linux -- Python 3.8.15, pytest-7.1.2, pluggy-1.0.0
rootdir: /home/lesteve/dev/scikit-learn, configfile: setup.cfg
plugins: forked-1.3.0, cov-3.0.0, xdist-2.5.0
collected 12 items                                                                                                                                                                                                                           

sklearn/covariance/tests/test_graphical_lasso.py ..FF........                                                                                                                                                                          [100%]

================================================================================================================== FAILURES ==================================================================================================================
____________________________________________________________________________________________________________ test_graph_lasso_2D _____________________________________________________________________________________________________________

    def test_graph_lasso_2D():
        # Hard-coded solution from Python skggm package
        # obtained by calling `quic(emp_cov, lam=.1, tol=1e-8)`
        cov_skggm = np.array([[3.09550269, 1.186972], [1.186972, 0.57713289]])
    
        icov_skggm = np.array([[1.52836773, -3.14334831], [-3.14334831, 8.19753385]])
        X = datasets.load_iris().data[:, 2:]
        emp_cov = empirical_covariance(X)
        for method in ("cd", "lars"):
>           cov, icov = graphical_lasso(emp_cov, alpha=0.1, return_costs=False, mode=method)

sklearn/covariance/tests/test_graphical_lasso.py:105: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
sklearn/covariance/_graph_lasso.py:257: in graphical_lasso
    _, _, coefs = lars_path_gram(
sklearn/linear_model/_least_angle.py:309: in lars_path_gram
    return _lars_path_solver(
sklearn/linear_model/_least_angle.py:731: in _lars_path_solver
    g1 = arrayfuncs.min_pos((C - Cov) / (AA - corr_eq_dir + tiny32))
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

>   return _min_pos[double](<double *> &X[0], X.size)
E   IndexError: Out of bounds on buffer access (axis 0)

sklearn/utils/arrayfuncs.pyx:27: IndexError
_____________________________________________________________________________________________________ test_graphical_lasso_iris_singular _____________________________________________________________________________________________________

    def test_graphical_lasso_iris_singular():
        # Small subset of rows to test the rank-deficient case
        # Need to choose samples such that none of the variances are zero
        indices = np.arange(10, 13)
    
        # Hard-coded solution from R glasso package for alpha=0.01
        cov_R = np.array(
            [
                [0.08, 0.056666662595, 0.00229729713223, 0.00153153142149],
                [0.056666662595, 0.082222222222, 0.00333333333333, 0.00222222222222],
                [0.002297297132, 0.003333333333, 0.00666666666667, 0.00009009009009],
                [0.001531531421, 0.002222222222, 0.00009009009009, 0.00222222222222],
            ]
        )
        icov_R = np.array(
            [
                [24.42244057, -16.831679593, 0.0, 0.0],
                [-16.83168201, 24.351841681, -6.206896552, -12.5],
                [0.0, -6.206896171, 153.103448276, 0.0],
                [0.0, -12.499999143, 0.0, 462.5],
            ]
        )
        X = datasets.load_iris().data[indices, :]
        emp_cov = empirical_covariance(X)
        for method in ("cd", "lars"):
>           cov, icov = graphical_lasso(
                emp_cov, alpha=0.01, return_costs=False, mode=method
            )

sklearn/covariance/tests/test_graphical_lasso.py:135: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
sklearn/covariance/_graph_lasso.py:257: in graphical_lasso
    _, _, coefs = lars_path_gram(
sklearn/linear_model/_least_angle.py:309: in lars_path_gram
    return _lars_path_solver(
sklearn/linear_model/_least_angle.py:731: in _lars_path_solver
    g1 = arrayfuncs.min_pos((C - Cov) / (AA - corr_eq_dir + tiny32))
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

>   return _min_pos[double](<double *> &X[0], X.size)
E   IndexError: Out of bounds on buffer access (axis 0)

sklearn/utils/arrayfuncs.pyx:27: IndexError
================================================================================================== 2 failed, 10 passed, 9 warnings in 0.73s ==================================================================================================

Vincent-Maladiere · 2023-02-02T09:54:52Z

Hey @rprkh, as @lesteve showed, the errors we observe on the CI are due to the flag SKLEARN_ENABLE_DEBUG_CYTHON_DIRECTIVES being set to 1, which removes some bound checks during the Cython compiling and ultimately leads to the IndexError we're having.

scikit-learn/sklearn/_build_utils/__init__.py

Lines 69 to 81 in 681e8e2

    
           # Additional checks for Cython 
        
           cython_enable_debug_directives = ( 
        
               os.environ.get("SKLEARN_ENABLE_DEBUG_CYTHON_DIRECTIVES", "0") != "0" 
        
           ) 
        
           compiler_directives = { 
        
               "language_level": 3, 
        
               "boundscheck": cython_enable_debug_directives, 
        
               "wraparound": False, 
        
               "initializedcheck": False, 
        
               "nonecheck": False, 
        
               "cdivision": True, 
        
           }

I need to take some time to investigate this issue in more depth. In the meantime, you can tackle another PR.

jeremiedbb · 2023-02-23T18:36:27Z

The issue happens when passing an empty array. Then X[0] is out of bound.
Actually there's no need to go through a private helper anymore when using a fused typed memoryview. You can replace min_pos by

def min_pos(const floating[:] X):
    """Find the minimum value of an array over positive values

    Returns the maximum representable value of the input dtype if none of the
    values are positive.
    """
    cdef Py_ssize_t i
    cdef floating min_val = FLT_MAX if floating is float else DBL_MAX
    for i in range(X.size):
        if 0. < X[i] < min_val:
            min_val = X[i]
    return min_val

and remove _min_pos.

rprkh · 2023-02-25T15:29:02Z

Added the changes. The CI is finally green.

thomasjpfan

Thank you for the PR!

thomasjpfan · 2023-02-25T15:32:10Z

sklearn/utils/arrayfuncs.pyx

@@ -4,37 +4,26 @@ Small collection of auxiliary functions that operate on arrays
 """

 cimport numpy as cnp
-import  numpy as np
+import numpy as np


We can remove the imports for np, cnp and also cnp.import_array, because they are no longer used in this file. This means we can remove the "include_np" from the setup.py. Concretely:

diff --git a/setup.py b/setup.py index 4466e0aa1a..5251eec836 100755 --- a/setup.py +++ b/setup.py @@ -440,7 +440,7 @@ extension_config = { "utils": [ {"sources": ["sparsefuncs_fast.pyx"], "include_np": True}, {"sources": ["_cython_blas.pyx"]}, - {"sources": ["arrayfuncs.pyx"], "include_np": True}, + {"sources": ["arrayfuncs.pyx"]}, { "sources": ["murmurhash.pyx", join("src", "MurmurHash3.cpp")], "include_dirs": ["src"], diff --git a/sklearn/utils/arrayfuncs.pyx b/sklearn/utils/arrayfuncs.pyx index bac50ce678..4cdb6d6145 100644 --- a/sklearn/utils/arrayfuncs.pyx +++ b/sklearn/utils/arrayfuncs.pyx @@ -3,8 +3,6 @@ Small collection of auxiliary functions that operate on arrays """ -cimport numpy as cnp -import numpy as np from cython cimport floating from libc.math cimport fabs from libc.float cimport DBL_MAX, FLT_MAX @@ -12,9 +10,6 @@ from libc.float cimport DBL_MAX, FLT_MAX from ._cython_blas cimport _copy, _rotg, _rot -cnp.import_array() - - def min_pos(const floating[:] X): """Find the minimum value of an array over positive values

thomasjpfan · 2023-02-25T16:27:38Z

Note, the failing test in the ci is unrelated to this PR and will be fixed in #25701.

jeremiedbb

LGTM. Thanks @rprkh

Changes were implemented

* ENH Raise NotFittedError in get_feature_names_out for MissingIndicator, KBinsDiscretizer, SplineTransformer, DictVectorizer (scikit-learn#25402) Co-authored-by: Alex <[email protected]> Co-authored-by: Guillaume Lemaitre <[email protected]> * DOC Update date and contributors list for v1.2.1 (scikit-learn#25459) * DOC Make MeanShift documentation clearer (scikit-learn#25305) Co-authored-by: Guillaume Lemaitre <[email protected]> * Finishes boolean and arithmetic creation * Skeleton for traditional GP * DOC Reorder whats_new/v1.2.rst (scikit-learn#25461) Follow-up of scikit-learn#25459 Co-authored-by: Olivier Grisel <[email protected]> Co-authored-by: Jérémie du Boisberranger <[email protected]> Co-authored-by: Olivier Grisel <[email protected]> Co-authored-by: Jérémie du Boisberranger <[email protected]> * FIX fix faulty test in `cross_validate` that used the wrong estimator (scikit-learn#25456) * ENH Raise NotFittedError in get_feature_names_out for estimators that use ClassNamePrefixFeatureOutMixin and SelectorMixin (scikit-learn#25308) Co-authored-by: Guillaume Lemaitre <[email protected]> * EFF Improve IsolationForest predict time (scikit-learn#25186) Co-authored-by: Felipe Breve Siola <[email protected]> Co-authored-by: Guillaume Lemaitre <[email protected]> Co-authored-by: Olivier Grisel <[email protected]> Co-authored-by: Tim Head <[email protected]> * MAINT refactor spectral_clustering to call SpectralClustering (scikit-learn#25392) * TST reduce warnings in test_logistic.py (scikit-learn#25469) * CI Build doc on CircleCI (scikit-learn#25466) * DOC Update news footer for 1.2.1 (scikit-learn#25472) * MAINT Validate parameter for `sklearn.cluster.cluster_optics_xi` (scikit-learn#25385) Co-authored-by: adossantosalfam <[email protected]> Co-authored-by: Guillaume Lemaitre <[email protected]> * MAINT Parameters validation for additive_chi2_kernel (scikit-learn#25424) Co-authored-by: Guillaume Lemaitre <[email protected]> * Initial Program Creation * CI Include linting in CircleCI (scikit-learn#25475) * MAINT Update version number to 1.2.1 in SECURITY.md (scikit-learn#25471) * TST Sets random_state for test_logistic.py (scikit-learn#25446) * MAINT Remove -Wcpp warnings when compiling sklearn.decomposition._online_lda_fast (scikit-learn#25020) Co-authored-by: Julien Jerphanion <[email protected]> * FIX Support readonly sparse datasets for `manhattan_distances` (scikit-learn#25432) * TST Add non-regression test for scikit-learn#7981 This reproducer is adapted from the one of this message: scikit-learn#7981 (comment) Co-authored-by: Loïc Estève <[email protected]> * FIX Support readonly sparse datasets for manhattan * DOC Add entry in whats_new/v1.2.rst for 1.2.1 * FIX Fix comment * Update sklearn/metrics/tests/test_pairwise.py Co-authored-by: Christian Lorentzen <[email protected]> * DOC Move entry to whats_new/v1.3.rst * Update sklearn/metrics/tests/test_pairwise.py Co-authored-by: Olivier Grisel <[email protected]> Co-authored-by: Loïc Estève <[email protected]> Co-authored-by: Christian Lorentzen <[email protected]> Co-authored-by: Olivier Grisel <[email protected]> * MAINT dynamically expose kulsinski and remove support in BallTree (scikit-learn#25417) Co-authored-by: Loïc Estève <[email protected]> Co-authored-by: Julien Jerphanion <[email protected]> closes scikit-learn#25212 * DOC Adds CirrusCI badge to readme (scikit-learn#25483) * CI add linter display name (scikit-learn#25485) * DOC update description of X in `FunctionTransformer.transform()` (scikit-learn#24844) * MAINT remove -Wcpp warnings when compiling sklearn.preprocessing._csr_polynomial_expansion (scikit-learn#25041) * DOC more didactic example of bisecting kmeans (scikit-learn#25494) Co-authored-by: Olivier Grisel <[email protected]> Co-authored-by: Arturo Amor <[email protected]> Co-authored-by: Jérémie du Boisberranger <[email protected]> * ENH csr_row_norms optimization (scikit-learn#24426) Co-authored-by: Julien Jerphanion <[email protected]> Co-authored-by: Guillaume Lemaitre <[email protected]> Co-authored-by: Jérémie du Boisberranger <[email protected]> * TST Allow callables as valid parameter regarding cloning estimator (scikit-learn#25498) Co-authored-by: Guillaume Lemaitre <[email protected]> Co-authored-by: Loïc Estève <[email protected]> Co-authored-by: From: Tim Head <[email protected]> * DOC Fixes sphinx search on website (scikit-learn#25504) * FIX make IsotonicRegression always predict NumPy arrays (scikit-learn#25500) Co-authored-by: Thomas J. Fan <[email protected]> * FEA Add Gamma deviance as loss function to HGBT (scikit-learn#22409) * FEA add gamma loss to HGBT * DOC add whatsnew * CLN address review comments * TST make test_gamma pass by not testing out-of-sample * TST compare gamma and poisson to LightGBM * TST fix test_gamma by comparing to MSE HGBT instead of Poisson HGBT * TST fix for test_same_predictions_regression for poisson * CLN address review comments * CLN nits * CLN better comments * TST use pytest.param with skip mark * TST Correct conditional test parametrization mark Co-authored-by: Christian Lorentzen <[email protected]> * CI Trigger CI Builds currently fail because requests to Azure Ubuntu repository timeout. * DOC add comment for lax comparison with LightGBM * CLN tuple needs trailing comma --------- Co-authored-by: Julien Jerphanion <[email protected]> * MAINT Remove -Wsign-compare warnings when compiling sklearn.tree._tree (scikit-learn#25507) * MAINT add more intuition on OAS computation based on literature (scikit-learn#23867) Co-authored-by: Guillaume Lemaitre <[email protected]> * CI Allow cirrus arm tests to run with cd build commit tag (scikit-learn#25514) * CI Upload ARM wheels from CirrusCI to nightly and staging index (scikit-learn#25513) Co-authored-by: Olivier Grisel <[email protected]> * MAINT Remove -Wcpp warnings from sklearn.utils._seq_dataset (scikit-learn#25406) * FIX Fixes linux ARM CI on CirrusCI (scikit-learn#25536) * DOC Fix grammatical mistake in `mixture` module (scikit-learn#25541) * DOC add missing trailing colon (scikit-learn#25542) * MAINT Parameters validation for sklearn.datasets.make_classification (scikit-learn#25474) Co-authored-by: Guillaume Lemaitre <[email protected]> * MNT Expose allow_nan tag in bagging (scikit-learn#25506) * MAINT Clean-up comments and rename variables in `_middle_term_sparse_sparse_{32, 64}` (scikit-learn#25449) Co-authored-by: Julien Jerphanion <[email protected]> * DOC: remove incorrect statement (scikit-learn#25544) * MAINT Parameters validation for reconstruct_from_patches_2d (scikit-learn#25384) Co-authored-by: Guillaume Lemaitre <[email protected]> * MAINT Parameter validation for sklearn.metrics.d2_pinball_score (scikit-learn#25414) Co-authored-by: Guillaume Lemaitre <[email protected]> Co-authored-by: Jérémie du Boisberranger <[email protected]> * MAINT Parameters validation for spectral_clustering (scikit-learn#25378) Co-authored-by: Guillaume Lemaitre <[email protected]> * MAINT Parameters validation for sklearn.datasets.fetch_kddcup99 (scikit-learn#25463) Co-authored-by: Guillaume Lemaitre <[email protected]> * DOC Update MLPRegressor docs (scikit-learn#25556) Co-authored-by: Ian Thompson <[email protected]> * DOC Update docs for KMeans (scikit-learn#25546) Co-authored-by: Jérémie du Boisberranger <[email protected]> * FIX BisectingKMeans crashes randomly (scikit-learn#25563) Fixes scikit-learn#25505 * ENH BaseLabelPropagation to accept sparse matrices (scikit-learn#19664) Co-authored-by: Kaushik Amar Das <[email protected]> Co-authored-by: Guillaume Lemaitre <[email protected]> * MAINT Remove travis ci config and related doc (scikit-learn#25562) * DOC Add pynndescent to Approximate nearest neighbors in TSNE example (scikit-learn#25480) Co-authored-by: Olivier Grisel <[email protected]> * DOC Add docstring example to make_regression (scikit-learn#25551) Co-authored-by: Thomas J. Fan <[email protected]> Co-authored-by: Jérémie du Boisberranger <[email protected]> * MAINT ensure that pos_label support all possible types (scikit-learn#25317) * MAINT Parameters validation for sklearn.metrics.f1_score (scikit-learn#25557) Co-authored-by: Jérémie du Boisberranger <[email protected]> * ENH Adds `class_names` to `tree.export_text` (scikit-learn#25387) Co-authored-by: Thomas J. Fan <[email protected]> Co-authored-by: Guillaume Lemaitre <[email protected]> * MAINT Replace cnp.ndarray with memory views in sklearn.tree._tree (where possible) (scikit-learn#25540) * DOC Change print format in TSNE example (scikit-learn#25569) Co-authored-by: Olivier Grisel <[email protected]> * FIX ColumnTransformer supports empty selection for pandas output (scikit-learn#25570) Co-authored-by: Julien Jerphanion <[email protected]> * DOC fix docstring of _plain_sgd (scikit-learn#25573) * FIX Enable setting of sub-parameters for deprecated base_estimator param (scikit-learn#25477) * DOC Improve minor and bug-fix release processes documentation (scikit-learn#25457) Co-authored-by: Olivier Grisel <[email protected]> Co-authored-by: Thomas J. Fan <[email protected]> Co-authored-by: Jérémie du Boisberranger <[email protected]> * MAINT Remove ReadonlyArrayWrapper from _loss module (scikit-learn#25555) * MAINT Remove ReadonlyArrayWrapper from _loss module * CLN Remove comments about Cython 3.0 * MAINT Remove ReadonlyArrayWrapper from _kmeans (scikit-learn#25554) * MAINT Remove ReadonlyArrayWrapper from _kmeans * more const and remove blas compile warnings * CLN Adds comment about casting to non const pointers * Update sklearn/utils/_cython_blas.pyx * MAINT Remove ReadonlyArrayWrapper from DistanceMetric (scikit-learn#25553) * DOC improve stop_words description w.r.t. max_df range in CountVectorizer (scikit-learn#25489) * MAINT Removes ReadOnlyWrapper (scikit-learn#25586) * MAINT Parameters validation for sklearn.metrics.log_loss (scikit-learn#25577) * MAINT Adds comments and better naming into tree code (scikit-learn#25576) * MAINT Adds comments and better naming into tree code * CLN Use feature_values instead of Xf * Apply suggestions from code review Co-authored-by: Adam Li <[email protected]> * DOC Improve comment from review * Apply suggestions from code review Co-authored-by: Julien Jerphanion <[email protected]> Co-authored-by: Olivier Grisel <[email protected]> --------- Co-authored-by: Adam Li <[email protected]> Co-authored-by: Julien Jerphanion <[email protected]> Co-authored-by: Olivier Grisel <[email protected]> * FIX error when deserialzing a Tree instance from a read only buffer (scikit-learn#25585) * DOC: fix typo in California Housing dataset description (scikit-learn#25613) * ENH: Update KDTree, and example documentation (scikit-learn#25482) * ENH: Update KDTree, and example documentation * ENH: Add valid metric function and reference doc * CHG: Documentation update Co-authored-by: Adam Li <[email protected]> * CHG: make valid metric property and fix doc string * FIX: documentation, and add code example * ENH: Change valid metric to class method, and doc * ENH: Change valid metric class variable, and doc * FIX: documentation error * FIX: documentation error * CHG: Use class method for valid metrics * FIX: CI problems --------- Co-authored-by: Adam Li <[email protected]> Co-authored-by: Julien Jerphanion <[email protected]> * TST Common test for checking estimator deserialization from a read only buffer (scikit-learn#25624) * DOC fix comment in plot_logistic_l1_l2_sparsity.py (scikit-learn#25633) Co-authored-by: Thomas J. Fan <[email protected]> * DOC Places governance in navigation bar (scikit-learn#25618) * MAINT Check pyproject toml is consistent with min_dependencies (scikit-learn#25610) * MAINT Check pyproject toml is consistent with min_dependencies * CLN Make it clear that only SciPy and Cython are checked * CLN Revert auto formatter * MAINT Use newest NumPy C API in tree._criterion (scikit-learn#25615) * MAINT Use newest NumPy C API in tree._criterion * FIX Use pointer for children * FIX Fixes check_array nonfinite checks with ArrayAPI specification (scikit-learn#25619) * FIX Fixes check_array nonfinite checks with ArrayAPI specification * DOC Adds PR number * FIX Test on both cupy and numpy * DOC Correctly docstring in StackingRegressor.fit_transform (scikit-learn#25599) * MAINT Remove Cython compilation warnings ahead of Cython3.0 release (scikit-learn#25621) * ENH Preserve DataFrame dtypes in transform for feature selectors (scikit-learn#25102) * FIX report properly n_iter_ when warm_start=True (scikit-learn#25443) Co-authored-by: Guillaume Lemaitre <[email protected]> * DOC fix typo in KMeans's param. (scikit-learn#25649) * FIX use const memory views in hist_gradient_boosting predictor (scikit-learn#25650) * DOC modified the graph for better readability (scikit-learn#25644) * MAINT Removes upper limit on setuptools (scikit-learn#25651) * DOC improve the `warm_start` glossary entry (scikit-learn#25523) * DOC Update governance document for SLEP020 (scikit-learn#25663) Co-authored-by: Tim Head <[email protected]> Co-authored-by: Christian Lorentzen <[email protected]> * FIX renormalization of y_pred inside log_loss (scikit-learn#25299) * Remove renormalization of y_pred inside log_loss * Deprecate eps parameter in log_loss * ENH Allows target to be pandas nullable dtypes (scikit-learn#25638) * DOC unify usage of 'w.r.t.' (scikit-learn#25683) * MAINT Parameters validation for metrics.max_error (scikit-learn#25679) * MAINT Parameters validation for datasets.make_friedman1 (scikit-learn#25674) Co-authored-by: jeremie du boisberranger <[email protected]> * MAINT Parameters validation for mean_pinball_loss (scikit-learn#25685) Co-authored-by: jeremie du boisberranger <[email protected]> * DOC Specify behavior of None for CountVectorizer (scikit-learn#25678) * DOC Specify behaviour of None for TfIdfVectorizer max_features parameter (scikit-learn#25676) Co-authored-by: Guillaume Lemaitre <[email protected]> * MAINT Set random state for plot_anomaly_comparison (scikit-learn#25675) * MAINT Parameters validation for cluster.mean_shift (scikit-learn#25684) Co-authored-by: jeremie du boisberranger <[email protected]> * MAINT Parameters validation for sklearn.metrics.jaccard_score (scikit-learn#25680) Co-authored-by: jeremie du boisberranger <[email protected]> * DOC Add the custom compiler section back (scikit-learn#25667) Co-authored-by: Thomas J. Fan <[email protected]> * MAINT Parameters validation for precision_recall_fscore_support (scikit-learn#25681) Co-authored-by: jeremie du boisberranger <[email protected]> * FIX Allow negative tol in SequentialFeatureSelector (scikit-learn#25664) * MAINT Replace deprecated cython conditional compilation (scikit-learn#25654) Co-authored-by: Guillaume Lemaitre <[email protected]> * DOC fix formatting typo in related_projects (scikit-learn#25706) * MAINT Parameters validation for metrics.mean_absolute_percentage_error (scikit-learn#25695) * MAINT Parameters validation for metrics.precision_recall_curve (scikit-learn#25698) Co-authored-by: jeremie du boisberranger <[email protected]> * MAINT Parameter Validation for metrics.precision_score (scikit-learn#25708) Co-authored-by: jeremie du boisberranger <[email protected]> * CI Stablize build with random_state (scikit-learn#25701) Co-authored-by: Jérémie du Boisberranger <[email protected]> * MAINT Remove -Wcpp warnings when compiling arrayfuncs (scikit-learn#25415) Co-authored-by: Thomas J. Fan <[email protected]> * DOC Add scikit-learn-intelex to related projects (scikit-learn#23766) Co-authored-by: Adrin Jalali <[email protected]> Co-authored-by: Thomas J. Fan <[email protected]> * ENH Support float32 in SGDClassifier and SGDRegressor (scikit-learn#25587) * FIX Raise appropriate attribute error in ensemble (scikit-learn#25668) * FIX Allow OrdinalEncoder's encoded_missing_value set to the cardinality (scikit-learn#25704) * ENH Let csr_row_norms support multi-thread (scikit-learn#25598) Co-authored-by: Jérémie du Boisberranger <[email protected]> Co-authored-by: Vincent M <[email protected]> * MAINT Parameter Validation for feature_selection.chi2 (scikit-learn#25719) Co-authored-by: jeremiedbb <[email protected]> * MAINT Parameter Validation for feature_selection.f_classif (scikit-learn#25720) Co-authored-by: Jérémie du Boisberranger <[email protected]> * MAINT Parameters validation for sklearn.metrics.matthews_corrcoef (scikit-learn#25712) Co-authored-by: jeremiedbb <[email protected]> * MAINT parameter validation for sklearn.datasets.dump_svmlight_file (scikit-learn#25726) Co-authored-by: jeremiedbb <[email protected]> * MAINT Clean dead code in build helpers (scikit-learn#25661) * MAINT Use newest NumPy C API in metrics._dist_metrics (scikit-learn#25702) * CI Adds permissions to workflows that use GITHUB_TOKEN (scikit-learn#25600) Co-authored-by: Olivier Grisel <[email protected]> * FIX Improves error message in partial_fit when early_stopping=True (scikit-learn#25694) Co-authored-by: Jérémie du Boisberranger <[email protected]> * DOC Makes navbar static (scikit-learn#25688) * MAINT Remove redundant sparse square euclidian distances function (scikit-learn#25731) * MAINT Use float64 for accumulators in WeightVector* (scikit-learn#25721) * API make PatchExtractor being a real scikit-learn transformer (scikit-learn#24230) Co-authored-by: Thomas J. Fan <[email protected]> Co-authored-by: Jérémie du Boisberranger <[email protected]> * MAINT Update pyparsing.py to use bool instead of double negation (scikit-learn#25724) * API Deprecates values in partial_dependence in favor of pdp_values (scikit-learn#21809) Co-authored-by: Guillaume Lemaitre <[email protected]> Co-authored-by: Jérémie du Boisberranger <[email protected]> * API Use grid_values instead of pdp_values in partial_dependence (scikit-learn#25732) * MAINT remove np.product and inf/nan aliases in favor of canonical names (scikit-learn#25741) * MAINT Parameters validation for metrics.label_ranking_loss (scikit-learn#25742) Co-authored-by: Jérémie du Boisberranger <[email protected]> * MAINT Parameters validation for metrics.coverage_error (scikit-learn#25748) * MAINT Parameters validation for metrics.dcg_score (scikit-learn#25749) * MAINT replace cnp.ndarray with memory views in _fast_dict (scikit-learn#25754) * MAINT Parameter Validation for feature_selection.f_regression (scikit-learn#25736) Co-authored-by: Jérémie du Boisberranger <[email protected]> * MAINT Parameters validation for feature_selection.r_regression (scikit-learn#25734) Co-authored-by: Jérémie du Boisberranger <[email protected]> * MAINT Parameter Validation for metrics.get_scorer (scikit-learn#25738) Co-authored-by: Jérémie du Boisberranger <[email protected]> * DOC Move allowing pandas nullable dtypes to 1.2.2 (scikit-learn#25692) * MAINT replace cnp.ndarray with memory views in sparsefuncs_fast (scikit-learn#25764) * MAINT parameter validation for sklearn.datasets.fetch_covtype (scikit-learn#25759) Co-authored-by: Jérémie du Boisberranger <[email protected]> * MAINT Define centralized generic, but with explicit precision, types (scikit-learn#25739) * CI Disable network when SciPy requires it (scikit-learn#25743) * CI Open issue when arm wheel fails on CirrusCI (scikit-learn#25620) * ENH Speed-up expected mutual information (scikit-learn#25713) Co-authored-by: Kshitij Mathur <[email protected]> Co-authored-by: Guillaume Lemaitre <[email protected]> Co-authored-by: Omar Salman <[email protected]> * FIX add retry mechanism to handle quotechar in read_csv (scikit-learn#25511) * Merge Population Creation (#1) --------- Co-authored-by: Alex Buzenet <[email protected]> Co-authored-by: Alex <[email protected]> Co-authored-by: Guillaume Lemaitre <[email protected]> Co-authored-by: Julien Jerphanion <[email protected]> Co-authored-by: Adam Kania <[email protected]> Co-authored-by: Olivier Grisel <[email protected]> Co-authored-by: Jérémie du Boisberranger <[email protected]> Co-authored-by: Shady el Gewily <[email protected]> Co-authored-by: John Pangas <[email protected]> Co-authored-by: Felipe Siola <[email protected]> Co-authored-by: Felipe Breve Siola <[email protected]> Co-authored-by: Tim Head <[email protected]> Co-authored-by: Christian Lorentzen <[email protected]> Co-authored-by: Loïc Estève <[email protected]> Co-authored-by: Anthony22-dev <[email protected]> Co-authored-by: adossantosalfam <[email protected]> Co-authored-by: Xiao Yuan <[email protected]> Co-authored-by: Thomas J. Fan <[email protected]> Co-authored-by: Omar Salman <[email protected]> Co-authored-by: Rahil Parikh <[email protected]> Co-authored-by: Gael Varoquaux <[email protected]> Co-authored-by: Arturo Amor <[email protected]> Co-authored-by: Jérémie du Boisberranger <[email protected]> Co-authored-by: Meekail Zain <[email protected]> Co-authored-by: davidblnc <[email protected]> Co-authored-by: Changyao Chen <[email protected]> Co-authored-by: Nicola Fanelli <[email protected]> Co-authored-by: Vincent M <[email protected]> Co-authored-by: partev <[email protected]> Co-authored-by: ouss1508 <[email protected]> Co-authored-by: ashah002 <[email protected]> Co-authored-by: Ahmedbgh <[email protected]> Co-authored-by: Pooja M <[email protected]> Co-authored-by: Ian Thompson <[email protected]> Co-authored-by: Ian Thompson <[email protected]> Co-authored-by: SANJAI_3 <[email protected]> Co-authored-by: Kaushik Amar Das <[email protected]> Co-authored-by: Kaushik Amar Das <[email protected]> Co-authored-by: Nawazish Alam <[email protected]> Co-authored-by: William M <[email protected]> Co-authored-by: Jérémie du Boisberranger <[email protected]> Co-authored-by: JanFidor <[email protected]> Co-authored-by: Adam Li <[email protected]> Co-authored-by: Logan Thomas <[email protected]> Co-authored-by: Vyom Pathak <[email protected]> Co-authored-by: as-90 <[email protected]> Co-authored-by: Marvin Krawutschke <[email protected]> Co-authored-by: Haesun Park <[email protected]> Co-authored-by: Christine P. Chai <[email protected]> Co-authored-by: Christian Veenhuis <[email protected]> Co-authored-by: Sortofamudkip <[email protected]> Co-authored-by: sonnivs <[email protected]> Co-authored-by: Ali H. El-Kassas <[email protected]> Co-authored-by: Yusuf Raji <[email protected]> Co-authored-by: Tabea Kossen <[email protected]> Co-authored-by: Pooja Subramaniam <[email protected]> Co-authored-by: JuliaSchoepp <[email protected]> Co-authored-by: Jack McIvor <[email protected]> Co-authored-by: zeeshan lone <[email protected]> Co-authored-by: Max Halford <[email protected]> Co-authored-by: Adrin Jalali <[email protected]> Co-authored-by: genvalen <[email protected]> Co-authored-by: Shiva chauhan <[email protected]> Co-authored-by: Dayne <[email protected]> Co-authored-by: Ralf Gommers <[email protected]> Co-authored-by: Kshitij Mathur <[email protected]>

rprkh added 4 commits January 10, 2023 23:38

new time series example

1f95ba6

remove unused imports and ignore warnings

bb8c0f0

lint

bd27ab0

remove wcpp warnings for arrayfuncs

233687d

github-actions bot added module:utils cython labels Jan 17, 2023

rprkh force-pushed the wcpp_warnings branch from 7e2361f to 233687d Compare January 17, 2023 08:02

fix

74cc9a0

glemaitre added the No Changelog Needed label Jan 17, 2023

glemaitre reviewed Jan 17, 2023

View reviewed changes

floating type

a8d7aff

rprkh force-pushed the wcpp_warnings branch from 5b88327 to a8d7aff Compare January 18, 2023 05:11

floating

fd8182c

Vincent-Maladiere reviewed Jan 19, 2023

View reviewed changes

sklearn/utils/arrayfuncs.pyx Outdated Show resolved Hide resolved

jjerphan approved these changes Jan 20, 2023

View reviewed changes

sklearn/utils/arrayfuncs.pyx Outdated Show resolved Hide resolved

sklearn/utils/arrayfuncs.pyx Outdated Show resolved Hide resolved

rprkh and others added 4 commits January 20, 2023 18:32

changes

e96b6e6

fix

2cce86a

Merge branch 'main' into wcpp_warnings

9df7bb3

merge

173a6d0

Merge branch 'main' into wcpp_warnings

8c00dd3

jjerphan previously requested changes Jan 23, 2023

View reviewed changes

sklearn/utils/arrayfuncs.pyx Outdated Show resolved Hide resolved

sklearn/utils/arrayfuncs.pyx Show resolved Hide resolved

rprkh added 2 commits January 23, 2023 23:40

const floating

e92c4be

revert cnp import array

ed52f59

rprkh force-pushed the wcpp_warnings branch 2 times, most recently from 0468e11 to ed52f59 Compare January 24, 2023 14:23

Merge branch 'main' into wcpp_warnings

9074521

rprkh force-pushed the wcpp_warnings branch from 93c3c4b to 9074521 Compare January 29, 2023 17:58

rprkh and others added 2 commits January 30, 2023 00:28

Merge branch 'main' into doc_new_example_time_series

3f0e359

Merge branch 'doc_new_example_time_series' of https://github.com/rprk…

e2f7be2

…h/scikit-learn into wcpp_warnings

rprkh and others added 5 commits February 25, 2023 18:46

changes

4337111

fix commit

81b9aaf

Merge branch 'main' into wcpp_warnings

30884ff

fix conflict

c11b25d

fix

ec4b2f4

thomasjpfan reviewed Feb 25, 2023

View reviewed changes

remove imports

7b9b53f

jeremiedbb approved these changes Feb 27, 2023

View reviewed changes

Merge branch 'main' into wcpp_warnings

d3da0ea

thomasjpfan approved these changes Feb 27, 2023

View reviewed changes

thomasjpfan changed the title ~~MAINT Remove -Wcpp warnings when compiling sklearn.utils.arrayfuncs~~ MAINT Remove -Wcpp warnings when compiling arrayfuncs Feb 27, 2023

thomasjpfan enabled auto-merge (squash) February 27, 2023 18:23

thomasjpfan disabled auto-merge February 27, 2023 19:29

thomasjpfan merged commit 5ba1fee into scikit-learn:main Feb 27, 2023

rprkh deleted the wcpp_warnings branch February 28, 2023 02:40

jjerphan mentioned this pull request Feb 28, 2023

MAINT Remove all Cython, C and C++ compilations warnings #24875

Closed

22 tasks

lesteve mentioned this pull request Nov 13, 2023

MAINT Remove -Wdiscarded-qualifiers compilation warning for sklearn.utils.arrayfuncs #27766

Merged



		def min_pos(cnp.ndarray X):
		def min_pos(ndarray[float64_t] X):

Uh oh!

MAINT Remove -Wcpp warnings when compiling arrayfuncs #25415

MAINT Remove -Wcpp warnings when compiling arrayfuncs #25415

Uh oh!

Conversation

rprkh commented Jan 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Any other comments?

Uh oh!

glemaitre Jan 17, 2023

Choose a reason for hiding this comment

Uh oh!

rprkh commented Jan 18, 2023

Uh oh!

Uh oh!

jjerphan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

rprkh commented Jan 20, 2023

Uh oh!

Vincent-Maladiere commented Jan 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rprkh commented Jan 23, 2023

Uh oh!

Uh oh!

Uh oh!

rprkh commented Jan 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Vincent-Maladiere commented Jan 31, 2023

Uh oh!

lesteve commented Feb 1, 2023

Uh oh!

lesteve commented Feb 1, 2023

Uh oh!

Vincent-Maladiere commented Feb 2, 2023

Uh oh!

jeremiedbb commented Feb 23, 2023

Uh oh!

rprkh commented Feb 25, 2023

Uh oh!

thomasjpfan left a comment

Choose a reason for hiding this comment

Uh oh!

thomasjpfan Feb 25, 2023

Choose a reason for hiding this comment

Uh oh!

thomasjpfan commented Feb 25, 2023

Uh oh!

jeremiedbb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rprkh commented Jan 17, 2023 •

edited

Loading

Vincent-Maladiere commented Jan 23, 2023 •

edited

Loading

rprkh commented Jan 31, 2023 •

edited

Loading