CI Enable native osx-arm64 wheels on Python 3.8 #25427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogrisel
approved these changes
Jan 18, 2023
There was a problem hiding this comment.
The cirrus ci output log for this build looks good an actually runs the tests for py38 macos arm64 as intended:
...
============================= test session starts ==============================
platform darwin -- Python 3.8.10, pytest-7.2.1, pluggy-1.0.0
rootdir: /private/var/folders/76/zy5ktkns50v6gt5g8r0sf6sc0000gn/T/cibw-run-gdthfp89/cp38-macosx_arm64/test_cwd
...
jjerphan
pushed a commit
to jjerphan/scikit-learn
that referenced
this pull request
Jan 20, 2023
[cd build cirrus] Co-authored-by: Olivier Grisel <[email protected]>
jjerphan
pushed a commit
to jjerphan/scikit-learn
that referenced
this pull request
Jan 20, 2023
[cd build cirrus] Co-authored-by: Olivier Grisel <[email protected]>
jjerphan
pushed a commit
to jjerphan/scikit-learn
that referenced
this pull request
Jan 23, 2023
[cd build cirrus] Co-authored-by: Olivier Grisel <[email protected]>
adrinjalali
pushed a commit
that referenced
this pull request
Jan 24, 2023
[cd build cirrus] Co-authored-by: Olivier Grisel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On
main, the Python 3.8 wheel build on Cirrus used cross compilation, which meant we were not able to test the wheel on CI. This PR uses the tip from cibuildwheel's FAQ to build and test on Cirrus CI.