DOC Improve visibility of warning message on example "Pitfalls in the interpretation of coefficients of linear models" #25441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I thought that we introduced it in the last PR. Sorry for that. I checked the rendering and it looks good. Thanks @ArturoAmorQ. Merging |
jjerphan
pushed a commit
to jjerphan/scikit-learn
that referenced
this pull request
Jan 23, 2023
… interpretation of coefficients of linear models" (scikit-learn#25441)
adrinjalali
pushed a commit
that referenced
this pull request
Jan 24, 2023
… interpretation of coefficients of linear models" (#25441)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
See #20451.
What does this implement/fix? Explain your changes.
As mentioned in this comment, the warning message introduced in #20451 is quite relevant for passing the intended messages of the example. Therefore it would gain visibility if stated in the header instead of appearing in a section at the end of the example.
Any other comments?
I also took the opportunity to fix the second plot in Failure of Machine Learning to infer causal effects notebook, which was not rendering properly.