Thanks to visit codestin.com
Credit goes to github.com

Skip to content

FIX use const memory views in hist_gradient_boosting predictor #25650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2023
Merged

FIX use const memory views in hist_gradient_boosting predictor #25650

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sklearn/ensemble/_hist_gradient_boosting/_predictor.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ from ._bitset cimport in_bitset_2d_memoryview


def _predict_from_raw_data( # raw data = non-binned data
node_struct [:] nodes,
const node_struct [:] nodes,
const X_DTYPE_C [:, :] numeric_data,
const BITSET_INNER_DTYPE_C [:, ::1] raw_left_cat_bitsets,
const BITSET_INNER_DTYPE_C [:, ::1] known_cat_bitsets,
Expand All @@ -34,7 +34,7 @@ def _predict_from_raw_data( # raw data = non-binned data


cdef inline Y_DTYPE_C _predict_one_from_raw_data(
node_struct [:] nodes,
const node_struct [:] nodes,
const X_DTYPE_C [:, :] numeric_data,
const BITSET_INNER_DTYPE_C [:, ::1] raw_left_cat_bitsets,
const BITSET_INNER_DTYPE_C [:, ::1] known_cat_bitsets,
Expand Down
10 changes: 1 addition & 9 deletions sklearn/ensemble/_hist_gradient_boosting/gradient_boosting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1165,15 +1165,7 @@ def _compute_partial_dependence_recursion(self, grid, target_features):
return averaged_predictions

def _more_tags(self):
return {
"allow_nan": True,
"_xfail_checks": {
"check_estimators_pickle": (
"The memory views of the nodes parameter need to be defined"
"as read only in the Cython implementation."
),
},
}
return {"allow_nan": True}

@abstractmethod
def _get_loss(self, sample_weight):
Expand Down