FIX TransformerMixin does not override index if transform=pandas #25747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
approved these changes
Mar 8, 2023
Member
glemaitre
left a comment
There was a problem hiding this comment.
I am fine with this proposal.
Member
|
@thomasjpfan in exchange, could you have a new look at #25733 😄 |
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Mar 8, 2023
jeremiedbb
pushed a commit
that referenced
this pull request
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #25730
What does this implement/fix? Explain your changes.
Looking back, setting the index may be too strict and may be intuitive for third party estimator developers.
Note that setting the columns is still required because estimators like
ColumnTransformerhasverbose_feature_names_outoptions that updates the column names. This wayget_feature_names_outis consistent with the dataframe out oftransform.Any other comments?
I am placing this on
1.2.2, but I am okay with pushing it to the next release if we do not come with a consensus.