-
-
Notifications
You must be signed in to change notification settings - Fork 26k
ENH Add float32
implementations for BallTree
and KDTree
#25914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
thomasjpfan
merged 47 commits into
scikit-learn:main
from
OmarManzoor:ball_and_kd_tree_float32
Aug 1, 2023
Merged
Changes from all commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
3cd705b
ENH add float32 support in BallTree and KDTree
OmarManzoor 2071c0e
Remove 32 variant for VALID_METRICS
OmarManzoor 9e35066
Fix import issue
OmarManzoor 98d4f68
Merge branch 'main' into ball_and_kd_tree_float32
OmarManzoor 301afc9
Add tests for ball tree
OmarManzoor 4e666f9
Fix tests and apply some suggestions
OmarManzoor 45b43a6
Add whatsnew entry
OmarManzoor 22d4e37
Update setup files
OmarManzoor af1aa2a
Update test_ball_tree
OmarManzoor 3093550
Setup.py: continue when sources is empty
OmarManzoor 169495f
Preserve dtype for return outputs and adjust tests
OmarManzoor ba1ce1b
Add a test for two point correlation
OmarManzoor c7d959a
Remove debug print
OmarManzoor 66c578a
Add assertions for float dtypes
OmarManzoor 2368aa8
Rename METRICS_TO_TEST
OmarManzoor 5b6c2bc
Revert tempita on simultaneous_sort function
OmarManzoor 96d54c1
Add similar tests for kd tree
OmarManzoor 3eef8fb
Merge branch 'main' into ball_and_kd_tree_float32
OmarManzoor 8801242
PR suggestions
22ffce5
Merge branch 'ball_and_kd_tree_float32' of https://github.com/OmarMan…
d3f6ff4
Merge branch 'main' into ball_and_kd_tree_float32
5a2c1e7
Additional changes needed to sync with main and include the distance …
11744c8
Fix imports in test_neighbors_tree.py
1e24cd9
Correct references to BallTree64 and KDTree64 in doc for neighbors
26ab322
Rollback some recent changes
65c3e2b
Fix the doc issue by removing extra metric from ball tree
9027a92
Change structure - Use a BallTree and KDTree class
292a3f0
Fix tests and related issues
0a5fea2
Further fixes and use properties to access attributes of specialized …
810b1ed
In _estimate_mi in mutual_info if y is continuous set it as np.float6…
b294a11
Revert new structure
0527e77
Parameterize applicable tests over 64 and 32 class versions
738724e
Address all PR suggestions
2d2da7f
Resolve conflicts
819377e
Merge branch 'main' into ball_and_kd_tree_float32
d1b3b49
Merge branch 'main' into ball_and_kd_tree_float32
jjerphan 56dacf5
PR suggestions
d8cd47e
Merge branch 'ball_and_kd_tree_float32' of https://github.com/OmarMan…
7e71367
PR suggestion: Use a public BallTree class that inherits from BallTree64
1d49d97
Merge branch 'main' into ball_and_kd_tree_float32
aa7cbe4
Applies PR suggestions
8a1433c
Remove additional metrics
OmarManzoor e5712ec
Merge branch 'main' into ball_and_kd_tree_float32
OmarManzoor 0d1a58e
Fix unintended error during merge with main
6327066
Merge branch 'main' into ball_and_kd_tree_float32
179eb06
Address PR suggestions
192dfc3
Add missing docs
OmarManzoor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.