ENH allows to overwrite read_csv parameter in fetch_openml #26433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasjpfan
approved these changes
May 25, 2023
|
I am going to open a subsequent PR to illustrate what this PR is allowing for. |
Co-authored-by: Thomas J. Fan <[email protected]>
|
I open #26436 which shows how useful this feature will be for copping with the Pandas breaking change. |
Co-authored-by: Adrin Jalali <[email protected]>
manudarmi
pushed a commit
to primait/scikit-learn
that referenced
this pull request
Jun 12, 2023
…arn#26433) Co-authored-by: Thomas J. Fan <[email protected]> Co-authored-by: Adrin Jalali <[email protected]>
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
…arn#26433) Co-authored-by: Thomas J. Fan <[email protected]> Co-authored-by: Adrin Jalali <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopening #25488
Context
As pointed out in #25878 (comment), pandas introduced a breaking change from 1.X to 2.X to consider
Noneas a missing value by default. If we want to avoid suffering from the breaking change and also not having a different behaviour depending on the pandas version, then we can set the defaultna_valuesinread_csvto the previous 1.X values, and announce a future change.However, to silence this
FutureWarning, we need our user to provide the future defaultna_valuesand thus we need to exposeread_csv_kwargs.This PR is the part that exposes
read_csv_kwargsto our user.