FIX only consider "?" as missing marker as per ARFF specs #26551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manudarmi
pushed a commit
to primait/scikit-learn
that referenced
this pull request
Jun 12, 2023
7 tasks
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #26436
Alternative proposed in #26436. Strictly following the ARFF specs, only
"?"is a missing values marker (c.f. https://www.cs.waikato.ac.nz/~ml/weka/arff.html).This PR proposes to follow these specs and does not use other default missing values marker defined by pandas.
If a user wants to overwrite this behaviour, the parameter
read_csv_kwargswill help.