CLN Renames missing_values_in_feature_mask #26580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjerphan
approved these changes
Jun 14, 2023
There was a problem hiding this comment.
Thank you for clarifying it, @thomasjpfan.
Nit: missing_mask ticks me a bit as a suffix.
missing_values_in_feature_mask (or missing_values_mask_per_feature) is a bit longer, but might it convey a more exact meaning for such arrays?
lorentzenchr
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Related to #26391 (comment)
What does this implement/fix? Explain your changes.
This PR renames
feature_has_missingvariable tomissing_values_in_feature_mask.missing_values_in_feature_maskis a boolean mask of size(n_features_in_,)that indicates if a feature has missing values.Any other comments?
This PR is only a rename and does not introduce any functional changes.