ENH run common tests for SparseCoder #26691
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4d8db48 to
3b8e328
Compare
glemaitre
reviewed
Nov 3, 2023
| :mod:`sklearn.decomposition` | ||
| ............................ | ||
|
|
||
| - |Fix| :meth:`decomposition.SparseCoder.transform` now preserves data |
There was a problem hiding this comment.
It seems that you have changes that are not related to this PR.
glemaitre
reviewed
Nov 3, 2023
| :mod:`sklearn.utils` | ||
| .................... | ||
|
|
||
| - |Enhancement| :func:`utils.estimator_checks._construct_instance` now accepts |
There was a problem hiding this comment.
You don't need to have an entry for this change because it is changes internals only.
glemaitre
reviewed
Nov 3, 2023
| @@ -394,3 +394,37 @@ def predict_proba(self, X): | |||
| @available_if(_check_response("decision_function")) | |||
| def decision_function(self, X): | |||
| return "decision_function" | |||
|
|
|||
|
|
|||
| class DictionaryRequiringEstimatorMock(BaseEstimator): | |||
glemaitre
reviewed
Nov 3, 2023
| @@ -435,14 +446,13 @@ def _construct_instance(Estimator): | |||
| ("est2", LogisticRegression(C=1)), | |||
| ] | |||
| ) | |||
| elif required_parameters in (["dictionary"],): | |||
There was a problem hiding this comment.
no need for the "dictionary" part but only check for the SparseCoder
glemaitre
reviewed
Nov 3, 2023
| @@ -1249,6 +1281,12 @@ def check_dtype_object(name, estimator_orig): | |||
| estimator = clone(estimator_orig) | |||
| y = _enforce_estimator_tags_y(estimator, y) | |||
|
|
|||
| # ensure n_features of dictionary == n_features of X for SparseCoder | |||
| if name == "SparseCoder": | |||
There was a problem hiding this comment.
So it seems that the complex things here is to generate a dictionary that depends on X ahead of time.
Maybe the least tricky way is to run check_estimator not from the common test but from the test module and inherit from SparseCoder a fit method that would generate the dictionary at fit time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #26482
What does this implement/fix? Explain your changes.
This PR runs
SparseCodercommon tests by acceptingdictionaryasrequired_parametersinutils.estimator_cheks._construct_instance.SparseCoderinstance inutils.estimator_cheks._construct_instancefunctionSparseCoderSparseCoderSparseCoder.transform()which was failing during common testsn_features_inof inputXshould matchn_featuresofprecomputed_dictionaryofSparseCoderget_features_outtests were skipped for SparseCoder due to SparseCoder'sfeature_names_inattribute not resetting based on input.Any other comments?