FIX mutual_info_regression when X is of integer dtype - #26748
Merged
Conversation
betatim
approved these changes
Jul 3, 2023
betatim
left a comment
Member
There was a problem hiding this comment.
Thanks for working on this. Looks reasonable to me.
To keep the review simple and sticking to the "One PR for one topic" I'd propose to not make unrelated changes to the change log.
Contributor
Author
|
Sure, I will revert the changelog changes and open another PR for it later. |
Micky774
approved these changes
Jul 3, 2023
Micky774
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thank you for the fix 😄
punndcoder28
pushed a commit
to punndcoder28/scikit-learn
that referenced
this pull request
Jul 29, 2023
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Sep 18, 2023
jeremiedbb
pushed a commit
that referenced
this pull request
Sep 20, 2023
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #26696.
What does this implement/fix? Explain your changes.
This PR converts
Xtofloat64dtype before callingscaleto avoid rounding to integers.Btw I reordered the changelog sections according to the 1.3 version and alphabetical order. If not desired I can revert.