CI Add Python 3.12 build #26886
Closed
CI Add Python 3.12 build #26886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is ready to review, the Python 3.12 build passes, the error is a HTTP 503 during codecov upload, so not related to this PR, see this build |
thomasjpfan
reviewed
Jul 24, 2023
There was a problem hiding this comment.
For testing Python dev versions, I prefer to add it to the wheel build directly and upload it to the nightly index.
I am -0.25 on adding a Python dev job to Azure, because the job is temporary. I see the Python 3.12 job getting removed when 3.12 comes out because one of the other jobs will start using it.
|
OK, makes sense. I guess one day, a Python dev "permanent" build may make sense as suggested in https://discuss.scientific-python.org/t/spec-4-nightly-wheels/474/3. For now making sure that we are ready for Python 3.12 is higher priority. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numpy and Scipy dev now have wheels for Python 3.12, this is a good opportunity to test scikit-learn with Python 3.12.
Locally the test suite run without errors with Python 3.12, let's see what the
We could also build and upload wheels to scientific-python-nightly-wheels, but maybe in a separate PR? Here is the Scipy PR that added wheels upload for Python 3.12 to draw inspiration from: scipy/scipy#18937.