MNT make type checkers happy with set_{method}_request methods #26911
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
mypy
(and other type checkers) happy by hard coding potentially generated methods to the parent class.This code is never run in runtime, and is only there for type checkers since
TYPE_CHECKING
isFalse
during runetime.Right now,
mypy
would complain with the code:and say:
with this PR, the above errors are gone. It's still not idea, since we're telling mypy methods exist even if they don't, and we don't tell it about their signature.
cc @thomasjpfan @glemaitre @rth