Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC Add link to text/plot_document_classification_20newsgroups example #26938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2023

Conversation

Tialo
Copy link
Contributor

@Tialo Tialo commented Jul 29, 2023

Reference Issues/PRs

This adds links to text examples as mentioned in #26927

What does this implement/fix? Explain your changes.

Link to plot_document_classification_20newsgroups.py example added to:

  1. TfidfVectorizer

Any other comments?

@github-actions
Copy link

github-actions bot commented Jul 29, 2023

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 7dc39d5. Link to the linter CI: here

@adrinjalali
Copy link
Member

Please limit this PR to TfIdf examples and list example files you're creating reference for in the description.

@Tialo
Copy link
Contributor Author

Tialo commented Jul 31, 2023

Example file plot_hashing_vs_dict_vectorizer.py contains not only TfidfVectorizer, but HashingVectorizer and other vectorizers mentioned in pr description. But i need to reference this example only in TfidfVectorizer, am I right?

And the same with other example files? @adrinjalali

@adrinjalali
Copy link
Member

If you limit your scope to a single example, then it's quite okay to reference it in all places that it's relevant :)

@Tialo
Copy link
Contributor Author

Tialo commented Jul 31, 2023

Okay so I will, split this PR to 3 different PRs one for each example file.

@Tialo Tialo force-pushed the docs/add-text-examples-links branch from 31cd094 to 6b88c6e Compare July 31, 2023 12:07
@Tialo Tialo force-pushed the docs/add-text-examples-links branch from 6b88c6e to 7dc39d5 Compare July 31, 2023 12:12
@Tialo Tialo changed the title DOC Add links to text examples DOC Add link to text/plot_document_classification_20newsgroups example Jul 31, 2023
@Tialo
Copy link
Contributor Author

Tialo commented Jul 31, 2023

@adrinjalali I removed changes related to examples other than plot_document_classification_20newsgroups .py

Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@glemaitre this could be an easy one?

@glemaitre glemaitre merged commit b00cbae into scikit-learn:main Aug 12, 2023
@glemaitre
Copy link
Member

LGTM on my side. Thanks @Tialo

@Tialo Tialo deleted the docs/add-text-examples-links branch August 12, 2023 10:37
TamaraAtanasoska pushed a commit to TamaraAtanasoska/scikit-learn that referenced this pull request Aug 21, 2023
akaashpatelmns pushed a commit to akaashp2000/scikit-learn that referenced this pull request Aug 25, 2023
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Sep 18, 2023
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants