ENH Improve warnings if func returns a dataframe in FunctionTransformer #26944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
approved these changes
Aug 21, 2023
Member
glemaitre
left a comment
There was a problem hiding this comment.
LGTM on my side. Thanks @thomasjpfan
ogrisel
approved these changes
Aug 28, 2023
Member
ogrisel
left a comment
There was a problem hiding this comment.
I find the use of the present tense in the warning message a bit confusing (see below) but other than that LGTM. Thanks for the UX fix!
Co-authored-by: Olivier Grisel <[email protected]>
Member
|
Thanks @thomasjpfan |
lesteve
pushed a commit
to lesteve/scikit-learn
that referenced
this pull request
Sep 28, 2023
…er (scikit-learn#26944) Co-authored-by: Olivier Grisel <[email protected]>
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
…er (scikit-learn#26944) Co-authored-by: Olivier Grisel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Closes #26552
What does this implement/fix? Explain your changes.
This PR implements the suggestion in #26552 (comment). The warning is now delayed to
transformand not inset_output.