-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
DOC Notebook style for ClassifierChain example #26956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@adrinjalali fyi |
@TomDLT would you have some bandwidth to review this one? (figured you might be a better person to review this than me since you reviewed the original ClassifierChain PR 😁 ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of comments.
But it looks much nicer. I also spotted that we have a bug if we would like to use a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @Tialo
Co-authored-by: Guillaume Lemaitre <[email protected]>
This PR suggests updates to ClassifierChain example to make it in notebook style formatting.
Reference Issues/PRs
This was suggested in #26937
What does this implement/fix? Explain your changes.
Any other comments?
If you have any suggestions/remarks feel free to share.