Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

AnneLaureF
Copy link

No description provided.

@agramfort
Copy link
Member

is tests pass +1 for the merge

@GaelVaroquaux
Copy link
Member

I have a failing doctest:

File "/home/varoquau/dev/scikit-learn/scikits/learn/grid_search.py", line 178, in scikits.learn.grid_search.GridSearchCV
Failed example:
    clf.fit(X, y).predict([[-0.8, -1]])
Expected:
    array([ 1.14])
Got:
    array([ 1.13101459])

It seems to me that this means that changing the score used has also changed which method performed best in the grid search. Is this to be expected? It will confuse users (but 0.6 is going to be a frightening release).

@agramfort
Copy link
Member

there is no reason it should be exactly the same but it should be close.
Doctest should be updated

@fabianp
Copy link
Member

fabianp commented Dec 8, 2010

I'll push this tomorrow if everyone is OK

@GaelVaroquaux
Copy link
Member

Yes. Thanks a lot.

Could you make sure that the doc test is fixed too.

@fabianp
Copy link
Member

fabianp commented Dec 10, 2010

It's in. All tests passed cleanly, nothing modified. Thanks AnneLaure for the patches.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants