Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ENH: Update numpy exceptions imports #27013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 8, 2023
Merged

ENH: Update numpy exceptions imports #27013

merged 3 commits into from
Aug 8, 2023

Conversation

mtsokol
Copy link
Contributor

@mtsokol mtsokol commented Aug 4, 2023

Reference Issues/PRs

Connected to numpy/numpy#24316.

What does this implement/fix? Explain your changes.

Due to NumPy's main namespace being changed in numpy/numpy#24316, here I update warning imports.

@github-actions
Copy link

github-actions bot commented Aug 4, 2023 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 69c2f99. Link to the linter CI: here

@mtsokol mtsokol force-pushed the update-np-exceptions-imports branch from 785d4f8 to d44672a Compare August 7, 2023 08:36
thomasjpfan
thomasjpfan reviewed Aug 7, 2023
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! I think the following lines can be updated to catch VisibleDeprecationWarning moving forward:

scikit-learn/build_tools/azure/test_script.sh

Line 52 in 3725ac1

TEST_CMD="$TEST_CMD -Werror::DeprecationWarning -Werror::FutureWarning -Werror::numpy.VisibleDeprecationWarning"

The np.VisibleDeprecationWarning can be replaced with:

-Werror::sklearn.utils.fixes.VisibleDeprecationWarning

@mtsokol mtsokol force-pushed the update-np-exceptions-imports branch from b9c4c60 to 2447534 Compare August 7, 2023 17:20
@mtsokol
Copy link
Contributor Author

mtsokol commented Aug 7, 2023

@thomasjpfan Sure! I updated the Azure CI script.

@thomasjpfan thomasjpfan mentioned this pull request Aug 7, 2023
Merged
thomasjpfan
thomasjpfan approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan added the Waiting for Second Reviewer First reviewer is done, need a second one! label Aug 7, 2023
rgommers
rgommers approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too. I'm merging the upstream PR with the removals now, so I'd suggest to get this in to avoid failures when the next numpy nightly is uploaded.

@betatim betatim merged commit 62b9e4a into scikit-learn:main Aug 8, 2023
@mtsokol mtsokol deleted the update-np-exceptions-imports branch August 8, 2023 07:25
TamaraAtanasoska pushed a commit to TamaraAtanasoska/scikit-learn that referenced this pull request Aug 21, 2023
@mtsokol @TamaraAtanasoska
ENH: Update numpy exceptions imports (scikit-learn#27013)
c6777ae
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Sep 18, 2023
@mtsokol @glemaitre
ENH: Update numpy exceptions imports (scikit-learn#27013)
d4a36e1
jeremiedbb pushed a commit that referenced this pull request Sep 20, 2023
@mtsokol @jeremiedbb
ENH: Update numpy exceptions imports (#27013)
0d4cda5
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
@mtsokol @REDVM
ENH: Update numpy exceptions imports (scikit-learn#27013)
cfcde93
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgommers rgommers rgommers approved these changes

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
module:utils Waiting for Second Reviewer First reviewer is done, need a second one!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mtsokol @rgommers @thomasjpfan @betatim