Thanks to visit codestin.com
Credit goes to github.com

Skip to content

MNT renames numpy alias of dtype in OrdinalEncoder #27050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

xuefeng-xu
Copy link
Contributor

Reference Issues/PRs

See #17687

@github-actions
Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 65c5d0c. Link to the linter CI: here

@thomasjpfan
Copy link
Member

thomasjpfan commented Aug 11, 2023

np.float64 is not an alias to a Python type. It is an actual NumPy dtype. More over, the documentation should match the actual default value:

@xuefeng-xu
Copy link
Contributor Author

np.float64 is not an alias to a Python type. It is an actual NumPy dtype. More over, the documentation should match the actual default value:

OK, but in this case, the default dtype of OneHotEncoder should also be set to np.float64 right?

dtype : number type, default=float

@thomasjpfan
Copy link
Member

Yes, I think OneHotEncoder's docs should have default=np.float64 to better represent what the code is doing.

@xuefeng-xu
Copy link
Contributor Author

Yes, I think OneHotEncoder's docs should have default=np.float64 to better represent what the code is doing.

Fixes in #27054

@xuefeng-xu xuefeng-xu deleted the dtype branch August 13, 2023 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants