-
-
Notifications
You must be signed in to change notification settings - Fork 26k
TST Extend tests for scipy.sparse.*array
in sklearn/cluster/tests/test_affinity_propagation
#27095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ogrisel
merged 5 commits into
scikit-learn:main
from
jjerphan:tst/sparse_array/test_affinity_propagation.py
Aug 18, 2023
Merged
TST Extend tests for scipy.sparse.*array
in sklearn/cluster/tests/test_affinity_propagation
#27095
ogrisel
merged 5 commits into
scikit-learn:main
from
jjerphan:tst/sparse_array/test_affinity_propagation.py
Aug 18, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e2ce044
to
bf89489
Compare
Signed-off-by: Julien Jerphanion <[email protected]>
Tests changed: - `test_affinity_propagation_precomputed_with_sparse_input` - `test_sparse_input_for_predict` - `test_sparse_input_for_fit_predict` Signed-off-by: Julien Jerphanion <[email protected]>
Tests changed: - `test_affinity_propagation_convergence_warning_dense_sparse` Signed-off-by: Julien Jerphanion <[email protected]>
bf89489
to
6717f99
Compare
glemaitre
reviewed
Aug 18, 2023
glemaitre
approved these changes
Aug 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, LGTM.
Co-authored-by: Guillaume Lemaitre <[email protected]>
Signed-off-by: Julien Jerphanion <[email protected]>
ogrisel
approved these changes
Aug 18, 2023
scipy.sparse.*array
in test_affinity_propagation.py
scipy.sparse.*array
in sklearn/cluster/tests/test_affinity_propagation
TamaraAtanasoska
pushed a commit
to TamaraAtanasoska/scikit-learn
that referenced
this pull request
Aug 21, 2023
…test_affinity_propagation` (scikit-learn#27095) Signed-off-by: Julien Jerphanion <[email protected]> Co-authored-by: Guillaume Lemaitre <[email protected]>
akaashpatelmns
pushed a commit
to akaashp2000/scikit-learn
that referenced
this pull request
Aug 25, 2023
…test_affinity_propagation` (scikit-learn#27095) Signed-off-by: Julien Jerphanion <[email protected]> Co-authored-by: Guillaume Lemaitre <[email protected]>
This was referenced Sep 4, 2023
elindgren
pushed a commit
to elindgren/scikit-learn
that referenced
this pull request
Oct 5, 2023
…test_affinity_propagation` (scikit-learn#27095) Signed-off-by: Julien Jerphanion <[email protected]> Co-authored-by: Guillaume Lemaitre <[email protected]>
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
…test_affinity_propagation` (scikit-learn#27095) Signed-off-by: Julien Jerphanion <[email protected]> Co-authored-by: Guillaume Lemaitre <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Towards #27090.
What does this implement/fix? Explain your changes.
This PR introduces sparse containers' list conditionnaly to the version of SciPy so that we can extend tests as part of #27090.
Any other comments?