Thanks to visit codestin.com
Credit goes to github.com

Skip to content

TST Extend tests for scipy.sparse.*array in sklearn/cluster/tests/test_affinity_propagation #27095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jjerphan
Copy link
Member

Reference Issues/PRs

Towards #27090.

What does this implement/fix? Explain your changes.

This PR introduces sparse containers' list conditionnaly to the version of SciPy so that we can extend tests as part of #27090.

Any other comments?

@jjerphan jjerphan force-pushed the tst/sparse_array/test_affinity_propagation.py branch from e2ce044 to bf89489 Compare August 18, 2023 09:12
@scikit-learn scikit-learn deleted a comment from github-actions bot Aug 18, 2023
@jjerphan jjerphan marked this pull request as ready for review August 18, 2023 09:32
Tests changed:
 - `test_affinity_propagation_precomputed_with_sparse_input`
 - `test_sparse_input_for_predict`
 - `test_sparse_input_for_fit_predict`

Signed-off-by: Julien Jerphanion <[email protected]>
Tests changed:
 - `test_affinity_propagation_convergence_warning_dense_sparse`

Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan jjerphan force-pushed the tst/sparse_array/test_affinity_propagation.py branch from bf89489 to 6717f99 Compare August 18, 2023 09:57
@github-actions
Copy link

github-actions bot commented Aug 18, 2023

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: a62452e. Link to the linter CI: here

Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM.

jjerphan and others added 2 commits August 18, 2023 12:00
@jjerphan jjerphan changed the title TST Extend tests for scipy.sparse.*array in test_affinity_propagation.py TST Extend tests for scipy.sparse.*array in sklearn/cluster/tests/test_affinity_propagation Aug 18, 2023
@ogrisel ogrisel enabled auto-merge (squash) August 18, 2023 10:12
@ogrisel ogrisel merged commit 88074c9 into scikit-learn:main Aug 18, 2023
@jjerphan jjerphan deleted the tst/sparse_array/test_affinity_propagation.py branch August 18, 2023 11:06
TamaraAtanasoska pushed a commit to TamaraAtanasoska/scikit-learn that referenced this pull request Aug 21, 2023
…test_affinity_propagation` (scikit-learn#27095)

Signed-off-by: Julien Jerphanion <[email protected]>
Co-authored-by: Guillaume Lemaitre <[email protected]>
akaashpatelmns pushed a commit to akaashp2000/scikit-learn that referenced this pull request Aug 25, 2023
…test_affinity_propagation` (scikit-learn#27095)

Signed-off-by: Julien Jerphanion <[email protected]>
Co-authored-by: Guillaume Lemaitre <[email protected]>
elindgren pushed a commit to elindgren/scikit-learn that referenced this pull request Oct 5, 2023
…test_affinity_propagation` (scikit-learn#27095)

Signed-off-by: Julien Jerphanion <[email protected]>
Co-authored-by: Guillaume Lemaitre <[email protected]>
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
…test_affinity_propagation` (scikit-learn#27095)

Signed-off-by: Julien Jerphanion <[email protected]>
Co-authored-by: Guillaume Lemaitre <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants