FIX Bisecting kmeans when data has 1 feature - #27243
Merged
Merged
Conversation
betatim
reviewed
Aug 30, 2023
betatim
reviewed
Aug 30, 2023
betatim
approved these changes
Aug 30, 2023
betatim
left a comment
Member
There was a problem hiding this comment.
Looks reasonable to me. The thing I don't understand is why this only happens if n_features=1. Wouldn't it happen always when n_features != 2?
Member
Author
|
When n_features > 2 we allocate an array to big but since we only access the first 2 elements later there's no out of bound issue |
Co-authored-by: Tim Head <[email protected]>
Member
|
Ah yes. So there is a bug for |
Member
Author
I wouldn't call it a bug but a sub-optimal memory management 😄 |
jjerphan
approved these changes
Aug 30, 2023
jjerphan
left a comment
Member
There was a problem hiding this comment.
LGTM.
Is predict also affected?
Member
Author
Nope |
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Sep 5, 2023
Co-authored-by: Tim Head <[email protected]>
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Sep 18, 2023
Co-authored-by: Tim Head <[email protected]>
jeremiedbb
added a commit
that referenced
this pull request
Sep 20, 2023
Co-authored-by: Tim Head <[email protected]>
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
Co-authored-by: Tim Head <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #27236