TST Refactor common tests for set_output #27258
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorentzenchr
approved these changes
Sep 10, 2023
Member
lorentzenchr
left a comment
There was a problem hiding this comment.
LGTM
Just some questions.
sklearn/utils/estimator_checks.py
Outdated
| if "2darray" not in tags["X_types"] or tags["no_validation"]: | ||
| return | ||
| except ImportError: # pragma: no cover | ||
| raise SkipTest("pandas is not installed: not checking set output") |
Member
There was a problem hiding this comment.
Suggested change
| raise SkipTest("pandas is not installed: not checking set output") | |
| raise SkipTest("pandas is not installed: not checking set_output") |
| def check_global_output_transform_pandas(name, transformer_orig): | ||
| """Check that setting globally the output of a transformer to pandas lead to the | ||
| right results.""" | ||
| def _check_set_output_transform_pandas_context(name, transformer_orig, context): |
Member
There was a problem hiding this comment.
Do we need this function any more? It just calls _check_set_output_transform_dataframe.
Member
Author
There was a problem hiding this comment.
I like to have it because it configures callable such as is_supported_dataframe, etc. for the dataframe library:
_check_set_output_transform_dataframe(
name,
transformer_orig,
"pandas",
is_supported_dataframe=lambda X: isinstance(X, pd.DataFrame),
create_dataframe=lambda X, columns, index: pd.DataFrame(
X, columns=columns, copy=False, index=index
),
assert_frame_equal=pd.testing.assert_frame_equal,
context=context,
)The alternative is to repeat the code in check_set_output_transform_pandas and check_global_output_transform_pandas
Comment on lines
+4653
to
+4654
| def check_set_output_transform_pandas(name, transformer_orig): | ||
| _check_set_output_transform_pandas_context(name, transformer_orig, "local") |
Member
There was a problem hiding this comment.
Same here, do we need it?
Answer can be yes as used in several places.
Co-authored-by: Christian Lorentzen <[email protected]>
Member
|
We can close this PR @thomasjpfan? |
Member
Author
|
Yes, lets close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Related to #25896
What does this implement/fix? Explain your changes.
This PR
set_outputcommon tests to be more generic so it is easier to extend and support polars DataFrames.set_outputcommon tests so they can share code.