FIX accept array-like in feature_names for plot_tree - #27292
Merged
Conversation
betatim
reviewed
Sep 5, 2023
Member
|
I don't know what we usually do in terms of adding a no-regression test for parameter validation bugs. Maybe we don't need one. What do others think? |
betatim
approved these changes
Sep 5, 2023
betatim
left a comment
Member
There was a problem hiding this comment.
After removing list this looks good to me.
Member
|
Thanks for the PR @rprkh. The docstring also needs to be updated. Please also add a entry in the what's new (1.3.1) |
Contributor
Author
|
Added the changes |
jeremiedbb
enabled auto-merge (squash)
September 6, 2023 10:19
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Sep 18, 2023
…arn#27292) Co-authored-by: Jérémie du Boisberranger <[email protected]>
jeremiedbb
added a commit
that referenced
this pull request
Sep 20, 2023
Co-authored-by: Jérémie du Boisberranger <[email protected]>
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
…arn#27292) Co-authored-by: Jérémie du Boisberranger <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Partially fixes #27271
What does this implement/fix? Explain your changes.
The
feature_namesparameter now accepts an array.Any other comments?
The code above will execute without any errors