Thanks to visit codestin.com
Credit goes to github.com

Skip to content

MAINT: Cleanup expired ndarray methods #27401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2023
Merged

MAINT: Cleanup expired ndarray methods #27401

merged 1 commit into from
Sep 19, 2023

Conversation

mtsokol
Copy link
Contributor

@mtsokol mtsokol commented Sep 17, 2023

Hi!
This PR reflects changes introduced in numpy/numpy#24682.

@github-actions
Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 9038b1a. Link to the linter CI: here

@mtsokol mtsokol mentioned this pull request Sep 17, 2023
Merged
@mtsokol
Copy link
Contributor Author

mtsokol commented Sep 19, 2023 •
edited
Loading

Hi! Would you have a spare time to review this PR?

lorentzenchr
lorentzenchr approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@lorentzenchr lorentzenchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for these cleanups.

@lorentzenchr lorentzenchr added the Quick Review For PRs that are quick to review label Sep 19, 2023
@lesteve lesteve merged commit c4659db into scikit-learn:main Sep 19, 2023
@lesteve
Copy link
Member

lesteve commented Sep 19, 2023

Merging, thanks!

@mtsokol mtsokol deleted the numpy-ndarray-class-cleanup branch September 19, 2023 14:43
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
@mtsokol @REDVM
MAINT: Cleanup expired ndarray methods (scikit-learn#27401)
f628012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesteve lesteve lesteve approved these changes

@lorentzenchr lorentzenchr lorentzenchr approved these changes

Assignees
No one assigned
Labels
module:tree No Changelog Needed Quick Review For PRs that are quick to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mtsokol @lesteve @lorentzenchr