FIX make dataset fetchers accept os.Pathlike for data_home - #27468
Merged
adrinjalali merged 9 commits intoSep 28, 2023
Conversation
glemaitre
self-requested a review
September 28, 2023 08:05
glemaitre
approved these changes
Sep 28, 2023
glemaitre
left a comment
Member
There was a problem hiding this comment.
LGTM on my side. Thanks @Charlie-XIAO
@adrinjalali do you want to have a look.
adrinjalali
approved these changes
Sep 28, 2023
adrinjalali
left a comment
Member
There was a problem hiding this comment.
Happy to merge, since this was supported already anyway. But I'm not sure if we really support ANY pathlike object though.
lesteve
pushed a commit
to lesteve/scikit-learn
that referenced
this pull request
Sep 28, 2023
…t-learn#27468) Co-authored-by: Guillaume Lemaitre <[email protected]>
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Oct 17, 2023
…t-learn#27468) Co-authored-by: Guillaume Lemaitre <[email protected]>
glemaitre
added a commit
that referenced
this pull request
Oct 23, 2023
Co-authored-by: Guillaume Lemaitre <[email protected]>
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
…t-learn#27468) Co-authored-by: Guillaume Lemaitre <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #27447.
What does this implement/fix? Explain your changes.
This PR changes the parameter constraints of the dataset fetchers from
[str, None]to[str, os.PathLike, None].Any other comments?
The functions do have the ability to handle
os.PathLike, but previouslyvalidate_paramsis disabling it. The unit test also only makes sure that it is able to handle thesedata_home, but does check explicitly for each data fetcher. Not sure if this is sufficient.