ENH Add Array API compatibility to Normalizer
#27558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betatim
reviewed
Oct 20, 2023
betatim
reviewed
Oct 20, 2023
betatim
reviewed
Oct 20, 2023
Member
|
@EdAbati looks like the test failures are real test failures related to the PR 🎉 |
ogrisel
approved these changes
Nov 14, 2023
Member
ogrisel
left a comment
There was a problem hiding this comment.
LGTM as well. Thanks for the PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Towards #26024
What does this implement/fix? Explain your changes.
It makes the
Normalizerimplementation compatible and tested with the Array API.