TST make sure to not have ties in sparse callable NN test #27567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrinjalali
approved these changes
Oct 11, 2023
…nto fix_callable_metric_tight
|
Setting auto-merge, thanks! |
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Oct 31, 2023
…rn#27567) Co-authored-by: Loïc Estève <[email protected]>
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
…rn#27567) Co-authored-by: Loïc Estève <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the issue seen in
scipy-dev. This is due to ties in the distance and a change of behaviour due to: numpy/numpy#24201I change the test to not have any tie because this is not the purpose of the test itself.
Close #27423
/usr/share/miniconda/envs/testvenv/lib/python3.11/site-packages/pandas/core/internals/blocks.py:534: FutureWarning ___________________ test_sparse_metric_callable[csr_matrix] ____________________ [gw1] linux -- Python 3.11.4 /usr/share/miniconda/envs/testvenv/bin/python csr_container = <class 'scipy.sparse._csr.csr_matrix'> @pytest.mark.parametrize("csr_container", CSR_CONTAINERS) def test_sparse_metric_callable(csr_container): def sparse_metric(x, y): # Metric accepting sparse matrix input (only) assert issparse(x) and issparse(y) return x.dot(y.T).toarray().item() [2, 1]])) func = <function assert_array_compare at 0x7f8ae6b65d00> kwds = {'err_msg': '', 'header': 'Arrays are not equal', 'strict': False, 'verbose': True} self = <contextlib._GeneratorContextManager object at 0x7f8ae6ba1810>