FIX validate properly zero_division=np.nan when used in parallel processing - #27573
Merged
Conversation
Member
Author
|
ping @jeremiedbb to be sure that I don't make any mistake in the testing. |
betatim
reviewed
Oct 12, 2023
jeremiedbb
approved these changes
Oct 12, 2023
jeremiedbb
left a comment
Member
There was a problem hiding this comment.
LGTM.
I thought that we could tweak Options to correctly handle nan detection but it does not make things simpler. This solution is simple and not confusing so let's go for it.
Member
Author
|
I thing that the failure was not linked (negative |
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Oct 17, 2023
glemaitre
added a commit
that referenced
this pull request
Oct 23, 2023
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Oct 31, 2023
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #27563
For the classification metrics, we make a constraint check with
constraints = Options(Real, {0.0, 1.0, np.nan}). The issue is that we will check if a value is in the set withnp.nan is constraints. In a single process,np.nanshould be the same singleton so we don't have any issue. However, in parallel process,np.nanis apparently no the same singleton and thenp.nanwill not benp.nan. This is indeed the case when running on of these score function (viamake_scorer) within a cross-validation loop.This PR intends to make public the
_NanConstraintvia the string"nan"such that we make the right check and not the use theisstatement.