Thanks to visit codestin.com
Credit goes to github.com

Skip to content

FIX Use torch.backends.mps.is_built() instead of torch.has_mps #27642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
glemaitre merged 2 commits into from
Oct 23, 2023
Merged

FIX Use torch.backends.mps.is_built() instead of torch.has_mps #27642

glemaitre merged 2 commits into from
Oct 23, 2023

Conversation

@ogrisel
Copy link
Member

@ogrisel ogrisel commented Oct 23, 2023

Follow-up on #27606 but the MPS device on macOS.

torch.has_mps raises a UserWarning with PyTorch 2.1.0:

In [1]: import torch

In [2]: torch.has_mps
<ipython-input-2-9f62291be6af>:1: UserWarning: 'has_mps' is deprecated, please use 'torch.backends.mps.is_built()'
  torch.has_mps

@github-actions
Copy link

github-actions bot commented Oct 23, 2023 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: e140a07. Link to the linter CI: here

@ogrisel ogrisel requested a review from betatim October 23, 2023 09:46
@ogrisel ogrisel mentioned this pull request Oct 23, 2023
Merged
@ogrisel ogrisel added the Quick Review For PRs that are quick to review label Oct 23, 2023
glemaitre
glemaitre approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @ogrisel

@glemaitre glemaitre merged commit 1f1329f into scikit-learn:main Oct 23, 2023
@ogrisel ogrisel deleted the pytorch-has_mps branch October 24, 2023 15:34
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Oct 31, 2023
@ogrisel @glemaitre
FIX Use torch.backends.mps.is_built() instead of torch.has_mps (sciki…
2c0bbc6 
…t-learn#27642)
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
@ogrisel @REDVM
FIX Use torch.backends.mps.is_built() instead of torch.has_mps (sciki…
2c2d538 
…t-learn#27642)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@betatim betatim betatim approved these changes

@glemaitre glemaitre glemaitre approved these changes

Assignees

No one assigned

Labels

Array API module:utils No Changelog Needed Quick Review For PRs that are quick to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ogrisel @betatim @glemaitre