FIX Improve HDBSCAN Error Message when checking for connected components #27678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Separate connected components warning
glemaitre
approved these changes
Oct 30, 2023
Member
glemaitre
left a comment
There was a problem hiding this comment.
I think this is worth to add an entry in the changelog as a fix that clarify the error message.
…arn into hdbscan_warning_fix
glemaitre
approved these changes
Nov 16, 2023
Member
glemaitre
left a comment
There was a problem hiding this comment.
Still LGTM. Need an additional reviewer to get it through.
OmarManzoor
approved these changes
Dec 4, 2023
Contributor
OmarManzoor
left a comment
There was a problem hiding this comment.
LGTM. Thanks @tataganesh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #27436
What does this implement/fix? Explain your changes.
Currently, for HDBCAN, it is checked if the number of connected components of the mutual reachability graph is greater than one. If it is, an exception is raised stating that some elements in the distance matrix have less than
min_samplesneighbours. This exception is now split into two distinct exceptions -min_samplesneighbours