MAINT use Voting and Stacking support missing values #27710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmarManzoor
reviewed
Dec 4, 2023
Contributor
OmarManzoor
left a comment
There was a problem hiding this comment.
Thanks for the PR @glemaitre
OmarManzoor
approved these changes
Dec 4, 2023
Contributor
OmarManzoor
left a comment
There was a problem hiding this comment.
LGTM. Thanks @glemaitre
thomasjpfan
approved these changes
Dec 5, 2023
| def _more_tags(self): | ||
| try: | ||
| allow_nan = all( | ||
| _safe_tags(est[1])["allow_nan"] if est[1] != "drop" else True |
Member
There was a problem hiding this comment.
I agree this is better than main. Unfortunately, our tag system for allowing nans do not work with pipelines.
REF: #27903
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #27709, it appears that using
DecisionTreein common tests would be better because:By changing the common tests, I came across an error regarding the
allow_nantag for both theVotingandStackingestimators.This PR makes 2 changes:
allow_nantags forVotingandStackingestimators