Thanks to visit codestin.com
Credit goes to github.com

Skip to content

MAINT Fix nightly wheels upload #27831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 23, 2023
Merged

MAINT Fix nightly wheels upload #27831

merged 1 commit into from
Nov 23, 2023

Conversation

lesteve
Copy link
Member

@lesteve lesteve commented Nov 23, 2023 •
edited
Loading

Looks like nightly wheels have not been uploaded to scientific-python-nightly-wheels following #27735. The latest files are from 3 days ago.

The reason is a missing [ and ] in the bash if condition which somehow does not turn into an error but into uploading the wheels to scikit-learn-wheels-staging rather than scientific-python-nightly-wheels.

From the upload log:

Run bash build_tools/github/upload_anaconda.sh
+ '[' schedule == schedule
build_tools/github/upload_anaconda.sh: line 7: [: missing `]'
+ '' == nightly ']'
build_tools/github/upload_anaconda.sh: line 7: : command not found
+ ANACONDA_ORG=scikit-learn-wheels-staging

@github-actions GitHub Actions
Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 6b6b8af. Link to the linter CI: here

seberg
seberg approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@seberg seberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arrg, sorry, thanks @lesteve... I think I probably even lost that change somewhere along the way :(.

glemaitre
glemaitre approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks both. LGTM.

@glemaitre
Copy link
Member

I enable auto-merge.

@glemaitre glemaitre enabled auto-merge (squash) November 23, 2023 10:22
@glemaitre glemaitre merged commit 1bcbc00 into scikit-learn:main Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seberg seberg seberg approved these changes

@glemaitre glemaitre glemaitre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lesteve @glemaitre @seberg