remove pandas from a CI configuration that has code coverage enabled #27978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Lock files are updated by running the script https://github.com/scikit-learn/scikit-learn/blob/main/build_tools/update_environments_and_lock_files.py. You can update a single lock-file by using Find the build you want to modify in this file and remove pandas from it. If you only modify the lock file your change will be reverted the next time someone or scikit-learn-bot updates the lockfiles. |
Contributor
Author
|
Find the build you want to modify in this file and remove pandas from it.
will do, thanks for explaining!
|
lesteve
approved these changes
Dec 19, 2023
Member
lesteve
left a comment
There was a problem hiding this comment.
It seems like this is working as expected regarding the coverage:
for example these lines were not covered before and are now covered:
from this codecov page
Member
|
Merging, thanks! |
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
As discussed in this comment thread, it seems that at the moment there are no tests that run without pandas installed and with coverage enabled for every push to a branch that has an open pull request.
(There are tests that run with that configuration, but in scheduled "nightly" jobs)
What does this implement/fix? Explain your changes.
I removed pandas from one of the lockfiles used for the azure posix tests. As this job's matrix also includes another lock file that does have pandas I think the tests that need pandas should still run; I will check that the project's coverage remains the same
Any other comments?