Adds __getitem__ to ColumnTransformer #27990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrinjalali
reviewed
Dec 25, 2023
Member
adrinjalali
left a comment
There was a problem hiding this comment.
Adding a test for when the key/subestimator name doesn't exist, and moving the changelog to 1.5, LGTM.
jnothman
approved these changes
Dec 27, 2023
adrinjalali
approved these changes
Dec 27, 2023
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Feb 10, 2024
Co-authored-by: Guillaume Lemaitre <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Closes #15346
What does this implement/fix? Explain your changes.
This PR adds a
__getitem__toColumnTransformer, which is the same ascolumntransformer.named_transformer_[...]. For now, the__getitem__is restricted to fitted column transformers.