EFF Optimize function utils.validation._check_pos_label_consistency #28051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasjpfan
reviewed
Jan 3, 2024
Member
thomasjpfan
left a comment
There was a problem hiding this comment.
Thank you for the PR! Overall looks good.
Please add an entry to the change log at doc/whats_new/v1.5.rst with tag |Efficiency|. Like the other entries there, please reference this pull request with :pr: and credit yourself (and other contributors if applicable) with :user:.
The changelog is public facing and _check_pos_label_consistency is a private function. Your changelog entry should reference public functions that are now more efficient: calibration_curve, brier_score_loss, precision_recall_curve, det_curve, roc_curve.
Contributor
Author
|
Thank you @thomasjpfan for your review! I just added the changes you suggested. |
Co-authored-by: Thomas J. Fan <[email protected]>
09956cc to
884cb07
Compare
thomasjpfan
reviewed
Jan 3, 2024
Co-authored-by: Thomas J. Fan <[email protected]>
thomasjpfan
reviewed
Jan 3, 2024
Co-authored-by: Thomas J. Fan <[email protected]>
Co-authored-by: Thomas J. Fan <[email protected]>
Co-authored-by: Thomas J. Fan <[email protected]>
Co-authored-by: Thomas J. Fan <[email protected]>
glemaitre
approved these changes
Jan 11, 2024
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Feb 10, 2024
…cikit-learn#28051) Co-authored-by: Thomas J. Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #28050
What does this implement/fix? Explain your changes.
Optimizing the function
_check_pos_label_consistencywhen the argumentpos_labelis notNoneby avoiding the applynp.uniqueto the classes.Any other comments?