ENH TfidfTransformer perserves np.float32 dtype #28136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmarManzoor
reviewed
Jan 18, 2024
Contributor
There was a problem hiding this comment.
Thanks for the PR @glemaitre. Should we have some tests to check the preservation?
thomasjpfan
reviewed
Jan 18, 2024
OmarManzoor
approved these changes
Jan 18, 2024
Contributor
OmarManzoor
left a comment
There was a problem hiding this comment.
LGTM. Thanks @glemaitre
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #11000
Follow-up to #18843
This PR allows the
TfidfTransformerto make the computation usingnp.float32without additional conversion.As a free launch, the
TfidfVectorizershould make less copy when settingdtype=np.float32.