Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC Added relation between ROC-AUC and Gini in docstring of roc_auc_score #28156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 19, 2024

Conversation

dzisandy
Copy link
Contributor

@dzisandy dzisandy commented Jan 17, 2024

Reference Issues/PRs

closes #28144.

What does this implement/fix? Explain your changes.

Fixed the docstring of roc_auc_score by adding some additional linkage to the Gini coefficient, as described in issue

Copy link

github-actions bot commented Jan 17, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 1bbff76. Link to the linter CI: here

@dzisandy dzisandy closed this Jan 17, 2024
@dzisandy dzisandy reopened this Jan 17, 2024
@glemaitre glemaitre self-requested a review January 17, 2024 21:30
Co-authored-by: Guillaume Lemaitre <[email protected]>
@dzisandy
Copy link
Contributor Author

@glemaitre your remarks improved it. Thanks.

Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @dzisandy

@glemaitre glemaitre merged commit 21fcab7 into scikit-learn:main Jan 19, 2024
Copy link
Member

@lorentzenchr lorentzenchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some after merge comments.
@dzisandy Could you address those in a new PR? That would be very nice.

@dzisandy
Copy link
Contributor Author

@lorentzenchr #28190

glemaitre added a commit to glemaitre/scikit-learn that referenced this pull request Feb 10, 2024
glemaitre added a commit to glemaitre/scikit-learn that referenced this pull request Feb 13, 2024
glemaitre added a commit that referenced this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC Need Gini coefficient implementation
4 participants