CI Remove temporary work-around related to scipy and pandas development wheel installing numpy<2 #28163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
approved these changes
Jan 18, 2024
ogrisel
approved these changes
Jan 19, 2024
Member
ogrisel
left a comment
There was a problem hiding this comment.
Thanks for the clean up and the non regression check!
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Feb 10, 2024
…nt wheel installing numpy<2 (scikit-learn#28163)
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Feb 13, 2024
…nt wheel installing numpy<2 (scikit-learn#28163)
glemaitre
pushed a commit
that referenced
this pull request
Feb 13, 2024
…nt wheel installing numpy<2 (#28163)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nowadays, scipy and pandas development wheel don't require numpy<2. I added a check for good measure so that the issue (using released numpy while thinking we test against numpy dev) does not happen again.
The work-around was originally done in #27899