ENH Checks pandas and polars directly #28195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Do you recall why we were ducktyping in the first place? |
Member
Author
It was an evolution of how we detect dataframes. It started with def _is_pandas_df(X):
if hasattr(X, "iloc"):
try:
import pandas as pd
return isinstance(X, pd.DataFrame)
except ImportError:
return False
return FalseBut there was overhead with importing pandas when pandas was installed, but not used. Then we shifted to getting the pandas module from |
glemaitre
reviewed
Jan 20, 2024
doc/whats_new/v1.4.rst
Outdated
| larger than the number of non-duplicate samples. | ||
| :pr:`28165` by :user:`Jérémie du Boisberranger <jeremiedbb>`. | ||
|
|
||
| - |Fix| Pandas and Polars dataframe are validated directly without ducktyping checks. |
Member
There was a problem hiding this comment.
I would not consider it a fix :) but rather an enhancement :)
OmarManzoor
approved these changes
Jan 22, 2024
Contributor
OmarManzoor
left a comment
There was a problem hiding this comment.
LGTM. Thanks @thomasjpfan
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Feb 10, 2024
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Feb 13, 2024
glemaitre
pushed a commit
that referenced
this pull request
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #28174
What does this implement/fix? Explain your changes.
This PR goes with the solution in #28174 (comment) .
There is no additional overhead because the pandas check is only used if it is in
sys.modules. It is insys.modulesonly if pandas is already imported by the user.