Thanks to visit codestin.com
Credit goes to github.com

Skip to content

FIX HistgradientBoosting with pandas extension dtypes #28385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 9, 2024

Conversation

lesteve
Copy link
Member

@lesteve lesteve commented Feb 8, 2024

Fix #28317

Copy link

github-actions bot commented Feb 8, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: bc3c405. Link to the linter CI: here

@lesteve
Copy link
Member Author

lesteve commented Feb 8, 2024

debian-32 error seems genuine, need to look into it.

@lesteve
Copy link
Member Author

lesteve commented Feb 8, 2024

The debian-32 is fixed, I pushed a changelog entry for 1.4.1

@lesteve lesteve changed the title FIX HistgradientBoosting with pandas nullable dtypes FIX HistgradientBoosting with pandas extension dtypes Feb 8, 2024
@glemaitre glemaitre added this to the 1.4.1 milestone Feb 8, 2024
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM. Thanks @lesteve

Copy link
Member

@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thank you, @lesteve.

@jjerphan jjerphan merged commit 569ed5e into scikit-learn:main Feb 9, 2024
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Feb 10, 2024
LeoGrin pushed a commit to LeoGrin/scikit-learn that referenced this pull request Feb 12, 2024
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HistGradientBoostingClassifier does not support pd.Int64Dtype in v1.4.0
3 participants