BUG: ensure list of tuples results in 1d masked array in cv_results, as opposed to 2d array #28571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as opposed to 2d array
|
Could you please push a commit with |
|
ah I was wondering why it wasn't caught by ci in the previous PR 😄 looks like it runs fine now: https://output.circle-artifacts.com/output/job/3086cd7c-3181-48f8-9fb3-e384850c1bbf/artifacts/0/doc/auto_examples/model_selection/plot_grid_search_text_feature_extraction.html |
|
cc @thomasjpfan |
thomasjpfan
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Addresses the CI failure reported in #28569
I don't think this needs a changelog entry because the unintentional change from #28352 hasn't reached users yet
What does this implement/fix? Explain your changes.
Any other comments?