[MRG] Fix [PLSRegression] The standard scikit interface should have the argument in lowercase "y" not uppercase "Y" #26945 #28604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremiedbb
reviewed
Mar 21, 2024
Member
jeremiedbb
left a comment
There was a problem hiding this comment.
Thanks for the PR @davidleon123. Just a few minor comments but looks good overall.
Contributor
Author
|
Thanks so much for the review @jeremiedbb |
jeremiedbb
approved these changes
Mar 25, 2024
Member
jeremiedbb
left a comment
There was a problem hiding this comment.
LGTM. Thanks @davidleon123.
Please push a commit with [doc build] in the commit message to make sure we don't introduce warnings in the examples.
Contributor
Author
|
Thanks @jeremiedbb |
glemaitre
approved these changes
Mar 28, 2024
Member
glemaitre
left a comment
There was a problem hiding this comment.
LGTM as well. Thanks @davidleon123
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #26945
This is to replace the stalled PR #27666
@glemaitre