Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix docstring for RFECV method cv_results_ #28646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2024
Merged

Fix docstring for RFECV method cv_results_ #28646

merged 1 commit into from
Mar 19, 2024

Conversation

miguelcsilva
Copy link
Contributor

Reference Issues/PRs

Fixes #28580

What does this implement/fix? Explain your changes.

Improves the documentation of the cv_results_ attribute to make it more explicit to the reader in which way the returned arrays are ordered.

Current docs:
old

Proposed docs:
new

Any other comments?

N/A

@github-actions GitHub Actions
Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 2bb8cb0. Link to the linter CI: here

ogrisel
ogrisel approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I checked the code and I agree with what is written in the new paragraph.

jeremiedbb
jeremiedbb approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @miguelcsilva

@jeremiedbb jeremiedbb merged commit b4a323a into scikit-learn:main Mar 19, 2024
@miguelcsilva miguelcsilva deleted the fix-docstring-rfecv-cv_results_ branch March 19, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@jeremiedbb jeremiedbb jeremiedbb approved these changes

Assignees
No one assigned
Labels
module:feature_selection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RFECV docstring does not state how the cv_results_ attribute is ordered by
3 participants
@miguelcsilva @ogrisel @jeremiedbb