Thanks to visit codestin.com
Credit goes to github.com

Skip to content

MAINT Fix badge links and underscores in README.rst file #28815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 12, 2024
Merged

MAINT Fix badge links and underscores in README.rst file #28815

merged 1 commit into from
Apr 12, 2024

Conversation

ChVeen
Copy link
Contributor

@ChVeen ChVeen commented Apr 11, 2024 •
edited by lesteve
Loading

Reference Issues/PRs

Fixes #28801

What does this implement/fix? Explain your changes.

This PR fixes the not working links in the README.rst file.
Furthermore, the _ could be removed as well.

Any other comments?

@github-actions GitHub Actions
Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 7d2331e. Link to the linter CI: here

jeremiedbb
jeremiedbb approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rendering looks good https://github.com/scikit-learn/scikit-learn/blob/7d2331ee9be4a3f0ce1552f25a25d1f8cb69d7cf/README.rst. Thanks @ChVeen

@jeremiedbb
Copy link
Member

@lesteve, the CI failure looks like the one you fixed in #28789

@lesteve
Copy link
Member

lesteve commented Apr 11, 2024 •
edited
Loading

Yes indeed, I restarted the build and that should get rid of it.

Here is the build log output for further reference:

[22/249] Compiling Cython source /Users/runner/work/1/s/sklearn/cluster/_hdbscan/_linkage.pyx
  FAILED: sklearn/cluster/_hdbscan/_linkage.cpython-312-darwin.so.p/sklearn/cluster/_hdbscan/_linkage.pyx.c
  cython -M --fast-fail -3 '-X language_level=3' '-X boundscheck=False' '-X wraparound=False' '-X initializedcheck=False' '-X nonecheck=False' '-X cdivision=True' '-X profile=False' --include-dir /Users/runner/work/1/s/build/cp312 /Users/runner/work/1/s/sklearn/cluster/_hdbscan/_linkage.pyx -o sklearn/cluster/_hdbscan/_linkage.cpython-312-darwin.so.p/sklearn/cluster/_hdbscan/_linkage.pyx.c

  Error compiling Cython file:
  ------------------------------------------------------------
  ...
  from libc.math cimport sqrt, exp

  from ..utils._typedefs cimport float64_t, float32_t, int32_t, intp_t
  ^
  ------------------------------------------------------------

  sklearn/metrics/_dist_metrics.pxd:3:0: 'sklearn/utils/_typedefs.pxd' not found

I have seen a variation of this in #28797 (comment).

I have spent some time today trying to reproduce on a OSX machine with the no-OpenMP lock-file (since for some reason it only seems to happen in the no-OpenMP build no idea why) but so far I have not been able to.

For now doing ad-hoc fixes like #28789 is probably good enough ...

I tried to look around but I am not sure whether this is something that Meson should deal with better or not ...

@lesteve lesteve merged commit 04e247e into scikit-learn:main Apr 12, 2024
@lesteve
Copy link
Member

lesteve commented Apr 12, 2024

Merging thanks!

@lesteve lesteve mentioned this pull request Apr 12, 2024
Closed
Eliza-Diggins added a commit to Eliza-Diggins/cluster_generator that referenced this pull request Jul 18, 2024
@Eliza-Diggins
Update README.rst
0458256 
fixing some stupid bug with underscores. See scikit-learn/scikit-learn#28815...
Eliza-Diggins added a commit to Eliza-Diggins/cluster_generator that referenced this pull request Aug 26, 2024
@Eliza-Diggins
Update README.rst
e31e236 
fixing some stupid bug with underscores. See scikit-learn/scikit-learn#28815...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremiedbb jeremiedbb jeremiedbb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bad rendering of the badge links in the README.rst file on github
3 participants
@ChVeen @jeremiedbb @lesteve