DOC Mention the renaming of check_estimator_sparse_data in 1.5 changelog #28968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrinjalali
approved these changes
May 7, 2024
betatim
approved these changes
May 7, 2024
jeremiedbb
added a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
May 20, 2024
jeremiedbb
added a commit
that referenced
this pull request
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #28966
This estimator check was split into 2 checks, one for sparse matrices and one for sparse arrays. It's not a public tool so I think that it's fine that it was done without deprecation, but since it's used by third party developers, we should at least mention it in the changelog.