Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Reduce iteration over steps in _sk_visual_block_ #29022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremiedbb merged 4 commits into from
Jul 1, 2025
Merged

Reduce iteration over steps in _sk_visual_block_ #29022

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0384dfe
Reduce iteration over steps in `_sk_visual_block_`
deepyaman May 14, 2024
50b481f
Cast `names` to list instead of keeping it a tuple
deepyaman May 17, 2024
99a2177
Update unit test rather than casting `names` tuple
deepyaman Nov 18, 2024
2c2ef80
Merge remote-tracking branch 'upstream/main' into pr/deepyaman/29022
jeremiedbb Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions sklearn/pipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1312,15 +1312,15 @@ def __sklearn_is_fitted__(self):
return False

def _sk_visual_block_(self):
_, estimators = zip(*self.steps)

def _get_name(name, est):
if est is None or est == "passthrough":
return f"{name}: passthrough"
# Is an estimator
return f"{name}: {est.__class__.__name__}"

names = [_get_name(name, est) for name, est in self.steps]
names, estimators = zip(
*[(_get_name(name, est), est) for name, est in self.steps]
)
name_details = [str(est) for est in estimators]
return _VisualBlock(
"serial",
Expand Down
4 changes: 2 additions & 2 deletions sklearn/utils/_repr_html/tests/test_estimator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,12 +99,12 @@ def test_get_visual_block_pipeline():
est_html_info = _get_visual_block(pipe)
assert est_html_info.kind == "serial"
assert est_html_info.estimators == tuple(step[1] for step in pipe.steps)
assert est_html_info.names == [
assert est_html_info.names == (
"imputer: SimpleImputer",
"do_nothing: passthrough",
"do_nothing_more: passthrough",
"classifier: LogisticRegression",
]
)
assert est_html_info.name_details == [str(est) for _, est in pipe.steps]


Expand Down