-
-
Notifications
You must be signed in to change notification settings - Fork 26k
ENH Add array_api compatibility to max_error
#29212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Had to change the type of Was there a reason why that was |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks again for you Array API PRs @EdAbati. Since you already had quite a bit of experience on those I was wondering if you wouldn't be interested in contributing on PRs that are a bit less well defined but potentially more impactful from a performance point of view? For instance I think we could improve the array API support for the |
Hi @ogrisel , sounds good! I was also looking at |
I triggered the CUDA CI for this PR https://github.com/scikit-learn/scikit-learn/actions/runs/9500016241 (Mostly for my own sake to use the CI a bit) |
Reference Issues/PRs
Towards #26024
What does this implement/fix? Explain your changes.
It makes the
max_error
implementation compatible and tested with the Array API.