FIX Lazy instantiate the ThreadpoolController #29235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lesteve
reviewed
Jun 12, 2024
lesteve
reviewed
Jun 13, 2024
|
Thanks a lot, merging! |
jeremiedbb
added a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Jul 2, 2024
jeremiedbb
added a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Jul 2, 2024
jeremiedbb
added a commit
that referenced
this pull request
Jul 2, 2024
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Sep 9, 2024
glemaitre
added a commit
that referenced
this pull request
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29145
This PR avoids to instantiate the ThreadpoolController, and therefore calling the OpenMP or OpenBLAS API, at import time. Instead, the controller is created only when needed for the first time.
It should make the behavior similar to before 1.5.0. @JCoder01 or @mabl could you test that this branch prevents the dead locks you observed ?