CLN remove unneeded copyrights #29257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pinging @GaelVaroquaux since some of them are INRIA and @ogrisel since some mentioned him.
I'm not sure exactly how we should handle these. I would think that Inria needs to be mentioned somewhere (eg mentioning that some authors have been employed by Inria and hence Inria owns the copyright of the related work), but better in a central document than in each of the files.
|
|
We're in a gray area here though. As in, every organization can claim copyright on the part of the work done by their employees. We don't have a CLA or a DCO in place (https://opensource.com/article/18/3/cla-vs-dco-whats-difference). We could of course mention INRIA in our COPYING, but then we would need to mention every entity from whom we have contributors, right? |
|
We could of course mention INRIA in our COPYING, but then we would need to mention every entity from whom we have contributors, right?
I'm just trying to avoid problems
|
|
Would you be okay with removing them as in this PR, and then putting in a central place if INRIA complains? |
|
Inria will not complain to you, it will just make my life hard internally. Hence I would prefer that the name is kept somewhere as a copyright attribution, just somewhere.
|
|
@GaelVaroquaux , what do you think of 1ffb7cf? |
|
I think it's great, thank you.
…On Jun 15, 2024, 09:48, at 09:48, Adrin Jalali ***@***.***> wrote:
@GaelVaroquaux , what do you think of
1ffb7cf?
--
Reply to this email directly or view it on GitHub:
#29257 (comment)
You are receiving this because you were mentioned.
Message ID:
***@***.***>
|
jjerphan
approved these changes
Jun 17, 2024
ogrisel
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did a
git grep -i copyright, then went through everything and ignored the legit ones.These are the ones that I think we can remove/change, but I'm also not 100% sure.
pinging @GaelVaroquaux since some of them are
INRIAand @ogrisel since some mentioned him.this is my response to @jjerphan 's comment here: #29250 (comment)